Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48070
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=MWZ4ImLMfkerheUmptGY+Edbh8Le69GltGiToNZHUnQrA+2xQdWeoDIhKQ/GRx08Xc
         ckaJcLkf3Xwy/DHVPRalLJn9EfYmJh6o7gUeVsL/ienjJzfFW02VMm0PJ8c1sxplS4L5
         RNusZ5wVFiM8LDNYao9KeHCWGGdxdJAgVboug=
MIME-Version: 1.0
In-Reply-To: <4BD1B459.3040007@hristov.com>
References: <4BD1B459.3040007@hristov.com>
Date: Fri, 23 Apr 2010 17:01:10 +0200
Message-ID: <o2hfe05d1541004230801gf0630e79g702e05d92dd029d6@mail.gmail.com>
To: Andrey Hristov <php@hristov.com>
Cc: pierre@php.net, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Bug #51647 Certificate file without private key (pk in 
	another file) doesn't work
From: pierre.php@gmail.com (Pierre Joye)

Andrey,

I'm not sure how and how much time I have to ask that but:

Please post that in the bug report, with your patch and the reproduce way.

But committing in the middle of a yet another huge patch for mysql is
not the way to go. I don't like huge patches changing dozen of things
at once. Feel free to do it in mysql if you feel like it but simply do
not do it in openssl (or any other for that matters).This exact commit
clearly shows the reasons.

Johannes asked you to revert this commit, and it seems that you don't
want to. So what should we do now? Fight to death or try to actually
figure out what you are trying to fix and fix it in a way that we are
100% (or 99%) that it won't break anything? I vote for the latter and
I suggest you to do the same, and revert that commit as well as
requested by Johannes and myself.

Cheers,

On Fri, Apr 23, 2010 at 4:53 PM, Andrey Hristov <php@hristov.com> wrote:
> Pierre,
> if you don't like the patch I have committed to openssl to fix the problem
> you can revert it, but only if you can provide a better one.
>
> The test case is ext/mysqli/tests/bug51647.phpt
>
> You need to start the MySQL server with the following options :
> ssl-ca=/path/to/cacert.pem
> ssl-cert=/path/to/server-cert.pem
> ssl-key=/path/to/server-key.pem
>
> All files you can find here:
> http://www.hristov.com/andrey/projects/php_stuff/certs/
>
> The client certificates are already in the SVN repository.
>
> Andrey
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org