Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:48013
Return-Path: <adam@adamharvey.name>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 33379 invoked from network); 20 Apr 2010 00:51:50 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 20 Apr 2010 00:51:50 -0000
Authentication-Results: pb1.pair.com header.from=adam@adamharvey.name; sender-id=unknown
Authentication-Results: pb1.pair.com smtp.mail=adam@adamharvey.name; spf=permerror; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain adamharvey.name from 209.85.221.191 cause and error)
X-PHP-List-Original-Sender: adam@adamharvey.name
X-Host-Fingerprint: 209.85.221.191 mail-qy0-f191.google.com  
Received: from [209.85.221.191] ([209.85.221.191:36655] helo=mail-qy0-f191.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 33/2D-63141-5AAFCCB4 for <internals@lists.php.net>; Mon, 19 Apr 2010 20:51:50 -0400
Received: by qyk29 with SMTP id 29so6260386qyk.2
        for <internals@lists.php.net>; Mon, 19 Apr 2010 17:51:47 -0700 (PDT)
MIME-Version: 1.0
Sender: adam@adamharvey.name
Received: by 10.229.232.138 with HTTP; Mon, 19 Apr 2010 17:51:27 -0700 (PDT)
In-Reply-To: <r2la46f95ab1004190918od4151411idc75ecf5c2dcee1b@mail.gmail.com>
References: <r2la46f95ab1004190918od4151411idc75ecf5c2dcee1b@mail.gmail.com>
Date: Tue, 20 Apr 2010 08:51:27 +0800
X-Google-Sender-Auth: dab069ee9c57d7ee
Received: by 10.229.217.148 with SMTP id hm20mr1251204qcb.38.1271724707220; 
	Mon, 19 Apr 2010 17:51:47 -0700 (PDT)
Message-ID: <g2ze50d0a481004191751u1896a457q39c04a0a8efe41d3@mail.gmail.com>
To: Mats Lindh <mats.lindh@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Patch for Bug #51344: FILTER_NULL_ON_FAILURE flag 
	automatically set in filter_input() functions.
From: aharvey@php.net (Adam Harvey)

Hi Mats,

On 20 April 2010 00:18, Mats Lindh <mats.lindh@gmail.com> wrote:
> The filter_input function has an errornous check for the
> FILTER_NULL_ON_FAILURE flag, where it returns NULL if it is NOT set,
> and not if it is set.
>
> I added the patch to the bug tracker over a week ago, but it seems
> like it has gone unnoticed:
>
> http://bugs.php.net/bug.php?id=51344
>
> Would be great if someone could take a quick look and apply the patch
> if it looks good. Test is also included in the patch.

Sorry about that: I do remember seeing the patch last weekend and
completely forgot about it by the time I was in front of a development
box. I'll have a look at it today.

Thanks for the heads up!

Adam