Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47983 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 9363 invoked from network); 15 Apr 2010 14:13:08 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Apr 2010 14:13:08 -0000 Authentication-Results: pb1.pair.com smtp.mail=zeev@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=zeev@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.25.124.185 as permitted sender) X-PHP-List-Original-Sender: zeev@zend.com X-Host-Fingerprint: 212.25.124.185 il-mr1.zend.com Received: from [212.25.124.185] ([212.25.124.185:33832] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 73/14-22079-2FE17CB4 for ; Thu, 15 Apr 2010 10:13:08 -0400 Received: from il-gw1.zend.com (unknown [10.1.1.21]) by il-mr1.zend.com (Postfix) with ESMTP id 6EAC8504D4; Thu, 15 Apr 2010 16:52:11 +0300 (IDT) Received: from LAP-ZEEV.zend.com ([10.1.2.50]) by il-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 15 Apr 2010 17:13:03 +0300 Message-ID: <7.0.1.0.2.20100415171003.15224c80@zend.com> X-Mailer: QUALCOMM Windows Eudora Version 7.0.1.0 Date: Thu, 15 Apr 2010 17:13:02 +0300 To: Ferenc Kovacs Cc: internals@lists.php.net In-Reply-To: References: <3bea96c41003301008va8ea1cbif8c16be11451eaf8@mail.gmail.com> <4BC4B553.3020807@oracle.com> <4BC4BBF9.4000903@oracle.com> <7.0.1.0.2.20100413215139.0dbcfdd8@zend.com> <7.0.1.0.2.20100415140350.0e2a5290@zend.com> <7.0.1.0.2.20100415141933.0e2a53d8@zend.com> <7.0.1.0.2.20100415143309.0e2a5a40@zend.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable X-OriginalArrivalTime: 15 Apr 2010 14:13:03.0404 (UTC) FILETIME=[C313A6C0:01CADCA5] Subject: Re: [PHP-DEV] [RFC] FPM INI syntax From: zeev@zend.com (Zeev Suraski) At 17:00 15/04/2010, Ferenc Kovacs wrote: >On Thu, Apr 15, 2010 at 1:38 PM, Zeev Suraski=20 ><zeev@zend.com> wrote: >At 14:30 15/04/2010, Ferenc Kovacs wrote: >Yep, this what I'm trying to say. I thought that=20 >the include parameter in the global.ini is just=20 >a normal config variabla, which isn't=20 >interpreted by the php parse ini method, only=20 >just tells the fpm, to include that files=20 >manualy and merge the contents of that files=20 >into the original configuration parsed from the global.ini. >But as far as I understand the patch and the=20 >discussion, it seems that Jerome proposed to=20 >change the internal working of the ini parsing,=20 >to add general support for includes. > > >Actually as far as I understand what you wrote=20 >in the 1st paragraph is exactly what was=20 >planned. =C2 There weren't any plans to touch the .ini parser itself in any= way. > > >- the include directive is not yet implemented because the >zend_ini_parser is not able to handle recursive calls (because of the >the state env which is global) > >This seems to like that Jerome is implying to=20 >change the zend_ini_parser to support includes. Not quite - he only wants to make the parser=20 reentrant, so that it would be possible to=20 implement include in a certain way. It doesn't=20 mean the parser itself will support include. BTW=20 - I think there are other ways to implement=20 include that don't require making the ini parser=20 reentrant but that's a different story. >If the includes are done by the fpm config=20 >loader/parser, then I don't understand why=20 >should the zend_ini_parser to be changed except=20 >the one case that Jerome wants to implement a=20 >general include support for the ini parser. In Jerome's approach the include logic will still=20 be at the fpm config loader/parser level, but=20 he's modifying the ZE ini parser slightly to make=20 it easier for him to implement it at that=20 level. The behavior of the ZE ini parser won't change. Zeev=20