Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47842 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7336 invoked from network); 9 Apr 2010 07:26:39 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Apr 2010 07:26:39 -0000 Authentication-Results: pb1.pair.com header.from=mls@pooteeweet.org; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=mls@pooteeweet.org; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain pooteeweet.org from 188.40.37.16 cause and error) X-PHP-List-Original-Sender: mls@pooteeweet.org X-Host-Fingerprint: 188.40.37.16 hq1.backendmedia.com Linux 2.6 Received: from [188.40.37.16] ([188.40.37.16:58663] helo=hq1.backendmedia.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0B/6A-54833-DA6DEBB4 for ; Fri, 09 Apr 2010 03:26:38 -0400 Received: from localhost (unknown [127.0.0.1]) by hq1.backendmedia.com (Postfix) with ESMTP id 229862E30008; Fri, 9 Apr 2010 07:26:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at backendmedia.com Received: from hq1.backendmedia.com ([127.0.0.1]) by localhost (hq1.backendmedia.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vseJypohEL4G; Fri, 9 Apr 2010 09:26:33 +0200 (CEST) Received: from [192.168.0.151] (217-162-131-234.dclient.hispeed.ch [217.162.131.234]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mls@pooteeweet.org) by hq1.backendmedia.com (Postfix) with ESMTPSA id 76D622E30004; Fri, 9 Apr 2010 09:26:33 +0200 (CEST) Mime-Version: 1.0 (Apple Message framework v1078) Content-Type: text/plain; charset=us-ascii In-Reply-To: Date: Fri, 9 Apr 2010 09:26:32 +0200 Cc: internals@lists.php.net Content-Transfer-Encoding: 7bit Message-ID: <5C772C71-F1CC-4AB3-9DE7-F34395FCBD0D@pooteeweet.org> References: <2ee8cd453723d98edfa4abce48460b33@beberlei.de> To: David Soria Parra X-Mailer: Apple Mail (2.1078) Subject: Re: [PHP-DEV] Re: Patch: Reflection Exception Messages From: mls@pooteeweet.org (Lukas Kahwe Smith) On 28.03.2010, at 17:59, David Soria Parra wrote: > On 2010-03-28, Benjamin Eberlei wrote: >> Index: ext/reflection/php_reflection.c >> =================================================================== >> --- ext/reflection/php_reflection.c (revision 296963) >> +++ ext/reflection/php_reflection.c (working copy) >> @@ -3425,7 +3425,7 @@ >> } else { >> efree(lc_name); >> zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, >> - "Method %s does not exist", name); >> + "Method %s::%s() does not exist", ce->name, name); >> return; >> } >> } >> @@ -3602,7 +3602,7 @@ >> } >> } >> zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, >> - "Property %s does not exist", name); >> + "Property %s::%s does not exist", ce->name, name); >> } >> /* }}} * >> >> The patch is against SVN trunk. > > looks good for me. if there are no objections from someone else I'll > commit it tomorrow. @David: seems like you forgot to commit this? regards, Lukas Kahwe Smith mls@pooteeweet.org