Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47827 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70767 invoked from network); 7 Apr 2010 19:30:14 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Apr 2010 19:30:14 -0000 Authentication-Results: pb1.pair.com header.from=zippy1981@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=zippy1981@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.176 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: zippy1981@gmail.com X-Host-Fingerprint: 209.85.210.176 mail-yx0-f176.google.com Received: from [209.85.210.176] ([209.85.210.176:33143] helo=mail-yx0-f176.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A2/9E-20534-54DDCBB4 for ; Wed, 07 Apr 2010 15:30:13 -0400 Received: by yxe6 with SMTP id 6so803430yxe.27 for ; Wed, 07 Apr 2010 12:30:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:cc:content-type; bh=mWwGJhuk62xz8MC3dAUdUzSu1T46R1PBvVmHm7nv39s=; b=x3LdtbAC/roGk1mIWyo5q7sS82J/akvd+/9BkcOhhkU1wWoaWgyERYIKJHdMq0+UkF T4uHlVxiittQ/f0G6mkI3R2yiPiaajBHiej+/+/hRzBeBEnZFrj6ie1JRmfP6cU2VZVd pn8+n0oPjIrSUphzYjKgR/o5DDoB23TB+CO+w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:cc:content-type; b=pIlhNG3VJgCTlKAqf5fXPjiOiKzMMJ8Ji7vU4zxmpMQr3iSRu8pqIk4lNpaqO/ri/s v3D6ffS1rZOpuvt6EZ9xTqanXw73VTe0JCyhtIAGvaMxuPZGhxtE3+987hEzgOFYFpOR cANmyM/5aK2FG6deAjI9bqhIK3jgCM7cgnk24= MIME-Version: 1.0 Received: by 10.90.88.8 with HTTP; Wed, 7 Apr 2010 12:30:10 -0700 (PDT) Date: Wed, 7 Apr 2010 15:30:10 -0400 Received: by 10.90.198.19 with SMTP id v19mr2126515agf.100.1270668610491; Wed, 07 Apr 2010 12:30:10 -0700 (PDT) Message-ID: To: Rasmus Lerdorf , Michael Graziano , valli@icsurselva.ch Cc: internals@lists.php.net Content-Type: multipart/alternative; boundary=0016362841da27d5090483aa976d Subject: Bug 47435[Was]: Re: [PHP-DEV] What gruntwork needs to be done From: zippy1981@gmail.com (Justin Dearing) --0016362841da27d5090483aa976d Content-Type: text/plain; charset=ISO-8859-1 Ramus, On Tue, Apr 6, 2010 at 1:34 PM, Rasmus Lerdorf wrote: > > Here is a straightforward (but not easy) one: > > http://bugs.php.net/bug.php?id=47435 > > I actually found it easy, slightly tedious, and not straightforward. I guess its perspective. I am CCing my former colleague Mike G who added is $.02 to the ticket at my request. I have submitted a patch that includes tests after Valli's suggestion. I have to add the IPv4 mapping code, and will do that tonight. If you could provide feedback on the rest I would appreciate it. Below are two proposals that I think belong in separate tickets. I will open these two tickets unless they are summarily rejected by Ramus. Valli's notes implied that FILTER_VALIDATE_IP should match CIDR netmask notations. eg 0.0.0.0/0 and ::1/128 should match. They do not. I propose a new flag called FILTER_FLAG_INCLUDE_CIDR_NETMASK that does match. I second Mike G's proposed additional "FILTER_FLAG_NO_SPECIAL_RANGE" that captures the union of the other sets as a convenient shortcut. Justin --0016362841da27d5090483aa976d--