Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47824 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 33985 invoked from network); 7 Apr 2010 16:07:36 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 7 Apr 2010 16:07:36 -0000 Authentication-Results: pb1.pair.com header.from=zippy1981@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=zippy1981@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: zippy1981@gmail.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:60756] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 75/08-20534-8CDACBB4 for ; Wed, 07 Apr 2010 12:07:36 -0400 Received: by gyf2 with SMTP id 2so623848gyf.29 for ; Wed, 07 Apr 2010 09:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:content-type; bh=YoTAl2ry2o1LbIQ6rNp06PMe4Rr/fMtPJVy2zrmQ66k=; b=u5wiyTAPujl/0E3Zir9AedQKt1p/NBfjgo+vppKSupU8rS6CndQk71f6KGiBoNM/kz QcSGWPPvg2wP11oAjOe8CjzZc0NIHDC1BD9P9Xpo8fZZgqIUHf8chIZREUxHSuQWFVDY dH7MiqLcPcFpHfz2WSpdAVo+qOEXKiteg3Wjc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=vw8GglUwq20+u9f73TVi/6GPDb566jPhgDpktUmdXi/8lQG2/IpwhKIgJWZSBWoIzr /FcNsMP15eJIC+Rcygv1oFx7lJy+IxMfAof73IGPBHQUBZMWYrQRJMSFBpoS4PfidFB0 2k0Q+09K2RumoKI+XcWQegrNWbG5nTH9ebkIM= MIME-Version: 1.0 Received: by 10.90.88.8 with HTTP; Wed, 7 Apr 2010 09:07:33 -0700 (PDT) Date: Wed, 7 Apr 2010 12:07:33 -0400 Received: by 10.90.198.19 with SMTP id v19mr2085127agf.100.1270656453585; Wed, 07 Apr 2010 09:07:33 -0700 (PDT) Message-ID: To: internals@lists.php.net Content-Type: multipart/alternative; boundary=0016362841da8c2d0e0483a7c205 Subject: Repetitive calling of Z_STRLEN_P(value) in ext/filter/logical_filter.c From: zippy1981@gmail.com (Justin Dearing) --0016362841da8c2d0e0483a7c205 Content-Type: text/plain; charset=ISO-8859-1 Hey, Sorry for pestering with excessive questions, but I've not done a lot of C programming. In filter.c, specificalyl in php_filter_validate_ip(), Z_STRLEN_P(value) gets called a lot. I know compilers tend to inline short functions, but are they smart enough to assign a variable to a repetive macro expansion? Justin --0016362841da8c2d0e0483a7c205--