Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47805 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 44225 invoked from network); 6 Apr 2010 14:25:49 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 6 Apr 2010 14:25:49 -0000 Authentication-Results: pb1.pair.com header.from=rquadling@googlemail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=rquadling@googlemail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.220.225 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: rquadling@googlemail.com X-Host-Fingerprint: 209.85.220.225 mail-fx0-f225.google.com Received: from [209.85.220.225] ([209.85.220.225:57360] helo=mail-fx0-f225.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F3/64-19932-B644BBB4 for ; Tue, 06 Apr 2010 10:25:48 -0400 Received: by fxm25 with SMTP id 25so29505fxm.23 for ; Tue, 06 Apr 2010 07:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:reply-to:in-reply-to :references:from:date:received:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=zFw/wiVM7XKTHgcpeU4lTLRiTTYlmGhie89vzPTGpFY=; b=RE7kCu8xXQtDQR6j/sPVxIPvHHbpyYFiB8qgfSok2gqNS6O7l5lkRCUWMYLDwxsfDx 0g87nFCrUnFs0v4R9te6HfWCKEBRD4cf9hGoSUDaX///fBt3k5zxGbokG8G3zuVEoCgf ygrIwCL4rBr2vAdmP9+olpMkqRucoDoGiWGz4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; b=f+Yiv222UBlivbF6Cs4wrn9DAoOaultH5ErmX1Pp2tmig/pWYbNVOCs1bbSnZyKyHN qUWdl14eoyF1kV9thZkiz3vddviBGT5tApVFUNxbjQG/T8covBzS/dHW+jVWXatDKQVG PeB4OuDIxc3Of8x3ivzBVuXbHu7Ov4Iu8R48U= MIME-Version: 1.0 Received: by 10.223.126.80 with HTTP; Tue, 6 Apr 2010 07:25:22 -0700 (PDT) Reply-To: RQuadling@googlemail.com In-Reply-To: References: <4BB4EC2F.1020502@smashlabs.com> <4BB4F50D.9090006@zend.com> <4BB4FCC0.3010301@zend.com> <1270312532.16398.4122.camel@guybrush> <4BB920A6.1050304@zend.com> Date: Tue, 6 Apr 2010 15:25:22 +0100 Received: by 10.223.11.18 with SMTP id r18mr7378994far.97.1270563943861; Tue, 06 Apr 2010 07:25:43 -0700 (PDT) Message-ID: To: Ferenc Kovacs Cc: Hannes Magnusson , Stanislav Malyshev , =?UTF-8?Q?Johannes_Schl=C3=BCter?= , internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] On constructors: BC Break and Class compiler Improvements From: rquadling@googlemail.com (Richard Quadling) On 6 April 2010 13:52, Ferenc Kovacs wrote: > > > On Tue, Apr 6, 2010 at 1:32 PM, Hannes Magnusson > wrote: >> >> 2010/4/6 Richard Quadling : >> > 2010/4/5 Stanislav Malyshev : >> >> Hi! >> >> >> >>> Given the feedback on the list I think it's ok. >> >>> Please make the BC break clear in the NEWS file so I remember to cop= y >> >>> it >> >>> in the announcement. >> >> >> >> OK, done. >> >> -- >> >> Stanislav Malyshev, Zend Software Architect >> >> stas@zend.com =C2=A0 http://www.zend.com/ >> >> (408)253-8829 =C2=A0 MSN: stas@zend.com >> >> >> >> -- >> >> PHP Internals - PHP Runtime Development Mailing List >> >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> >> >> >> > >> > I've just done a quick check on PEAR/packages-all with regard to >> > classes using __construct vs the class name. >> > >> > 818 classes have __construct >> > 1511 use the class name as the constructor >> > 3563 files don't have a constructor >> > >> > I excluded tests, examples and documentation (but some may have crept >> > in). >> > >> >> None of those use namespaces, so there is no break there. >> >> -Hannes >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > should we check pear2? > > Tyrael > Doh. Well at least you all know what you are talking about. Same check on PEAR2... It seems the only places where classnames are used as constructors are in pyrus.phar and sandbox\SimpleChannelServer\pearscs.phar for Pyrus\pyrus.phar : PEAR_Task_Replace_rw Pyrus\pyrus.phar : PEAR_Task_Unixeol_rw Pyrus\pyrus.phar : PEAR_Task_Windowseol_rw Pyrus\pyrus.phar : Net_URL sandbox\SimpleChannelServer\pearscs.phar : PEAR_Task_Replace_rw sandbox\SimpleChannelServer\pearscs.phar : PEAR_Task_Unixeol_rw sandbox\SimpleChannelServer\pearscs.phar : PEAR_Task_Windowseol_rw As these are PEAR classes and don't aren't namespace, the current PEAR2/all looks OK too. Richard. --=20 ----- Richard Quadling "Standing on the shoulders of some very clever giants!" EE : http://www.experts-exchange.com/M_248814.html EE4Free : http://www.experts-exchange.com/becomeAnExpert.jsp Zend Certified Engineer : http://zend.com/zce.php?c=3DZEND002498&r=3D213474= 731 ZOPA : http://uk.zopa.com/member/RQuadling