Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47796
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.210.178 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=fQ/3cwudHPG6rrTY/z2nW9Lse1c4AKQzeTZSMWr3tT6Gh/YGfPTH2oCw5najhSoalL
         OvVFPkegcZXaS2GwRmp4gkv1RWvcNwPlhgY5Adv4UbN+bqwbydenyyEdioDhH7J2JmiM
         5ZqbuFnc8nBUSG5CMXShgrtM5tllvvtotOQds=
MIME-Version: 1.0
In-Reply-To: <q2o5458db3c1004051350se70b2705ue9367f34686ffe46@mail.gmail.com>
References: <s2h5458db3c1004051001n92294063s60da7f295cb985bb@mail.gmail.com>
	 <j2zfe05d1541004051008s1b90490ew12db18f1c34bbf16@mail.gmail.com>
	 <q2o5458db3c1004051350se70b2705ue9367f34686ffe46@mail.gmail.com>
Date: Mon, 5 Apr 2010 16:57:04 -0400
Message-ID: <p2q5458db3c1004051357rd470f5c0ua563281468160052@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=001636284ca2455abd04838392bd
Subject: Fwd: [PHP-DEV] Newbie contributor question, nmake test will not run 
	my patch
From: zippy1981@gmail.com (Justin Dearing)

--001636284ca2455abd04838392bd
Content-Type: text/plain; charset=ISO-8859-1

I did not hit "reply-all"

---------- Forwarded message ----------
From: Justin Dearing <zippy1981@gmail.com>
Date: Mon, Apr 5, 2010 at 4:50 PM
Subject: Re: [PHP-DEV] Newbie contributor question, nmake test will not run
my patch
To: Pierre Joye <pierre.php@gmail.com>


Pierre,

Thank you for your reply. Allow me to clarify.

I meant that I ran "nmake test," saved the output, opened it in a text
editor and found no mention of bug50698.phpt. I then ran run-tests.php
directly as you suggested, and saved the output to a html file. In that html
file it said the test was skipped because the copy of PHP.exe did nto have
CGI support. I reran configure, recompiled and ran run-tests.php one more
time. This time the test passed. However, when I reran "nmake test" there
was still no mention of bug50698.phpt in the build output.

I opened the makefile and the only action for target tests: is:
"$(BUILD_DIR)\php.exe" -d open_basedir= -d output_buffering=0 run-tests.php
$(TESTS) -p "$(BUILD_DIR)\php.exe"
I could not determine what set $(TESTS) so I used (http://processhacker(
processhacker.sf.net) to get the command line arguments of the running PHP
process. It was:
Debug_TS\php.exe -d open_basedir= -d output_buffering=0 run-tests.php -p
"Debug_TS\php.exe"

So I don't understand why some tests are getting skipped, or not mentioned
in the log file at least. To determine if its a logging problem I am
currently running
php.exe -d open_basedir= -d output_buffering=0 run-tests.php -p
"Debug_TS\php.exe" --html nmake-test-report.html
on my machine. Its a pentium IV so it will take a while I will report the
results when it is done.

Justin

On Mon, Apr 5, 2010 at 1:08 PM, Pierre Joye <pierre.php@gmail.com> wrote:

> hi,
>
> What do you mean by "does not show up"?
>
> to run tests, use:
>
> php run-test.php [options, use -h to see all options] ext/soap/tests
>
> Cheers,
>
> On Mon, Apr 5, 2010 at 7:01 PM, Justin Dearing <zippy1981@gmail.com>
> wrote:
> > Hi,
> >
> > So I wrote a test for bug 50698 (http://bugs.php.net/bug.php?id=50698),
> but
> > it doesn't show up in the test output when i run nmake test. I don't see
> > anything on the QA site about what to do to make a test run. I placed it
> in
> > the right directory and named it right as far as I can tell.
> >
> > What am I doing wrong and where is the link explaining what I am doing
> > wrong?
> >
> > Justin
> >
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>

--001636284ca2455abd04838392bd--