Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47670 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 95084 invoked from network); 28 Mar 2010 15:59:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Mar 2010 15:59:30 -0000 X-Host-Fingerprint: 217.114.211.68 unknown Date: Sun, 28 Mar 2010 10:59:29 -0500 Received: from [217.114.211.68] ([217.114.211.68:26301] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 31/4A-06536-1EC7FAB4 for ; Sun, 28 Mar 2010 10:59:29 -0500 To: internals@lists.php.net References: <2ee8cd453723d98edfa4abce48460b33@beberlei.de> User-Agent: slrn/0.9.9p1 (SunOS) Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: X-Posted-By: 217.114.211.68 Subject: Re: Patch: Reflection Exception Messages From: dsp@php.net (David Soria Parra) On 2010-03-28, Benjamin Eberlei wrote: > Index: ext/reflection/php_reflection.c >=================================================================== > --- ext/reflection/php_reflection.c (revision 296963) > +++ ext/reflection/php_reflection.c (working copy) > @@ -3425,7 +3425,7 @@ > } else { > efree(lc_name); > zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, > - "Method %s does not exist", name); > + "Method %s::%s() does not exist", ce->name, name); > return; > } > } > @@ -3602,7 +3602,7 @@ > } > } > zend_throw_exception_ex(reflection_exception_ptr, 0 TSRMLS_CC, > - "Property %s does not exist", name); > + "Property %s::%s does not exist", ce->name, name); > } > /* }}} * > > The patch is against SVN trunk. looks good for me. if there are no objections from someone else I'll commit it tomorrow.