Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47575
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain seanius.net from 66.93.22.232 cause and error)
Date: Wed, 24 Mar 2010 19:04:50 +0100
To: Pierre Joye <pierre.php@gmail.com>
Cc: Michael Maclean <michael@no-surprises.co.uk>, internals@lists.php.net
Message-ID: <20100324180450.GA13860@rangda.stickybit.se>
References: <4BA93A30.4040003@no-surprises.co.uk>
 <20100323224105.GA9531@rangda.stickybit.se>
 <4BA94C31.2020308@no-surprises.co.uk>
 <20100324064852.GA11983@rangda.stickybit.se>
 <fe05d1541003240226n26369a5fvbeb6f0f4ccfbe4e1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR"
Content-Disposition: inline
In-Reply-To: <fe05d1541003240226n26369a5fvbeb6f0f4ccfbe4e1@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: [PHP-DEV] [PATCH] FNV-1 support for ext/hash
From: seanius@seanius.net (sean finney)

--T4sUOijqQbZv57TR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 24, 2010 at 10:26:45AM +0100, Pierre Joye wrote:
> As far as I can tell that's not only for the hash module. Many areas
> in php and its libraries rely on (u)int instead of size_t. It is or
> was a common mistake. The problem is to change the signature now
> without breaking ABI.
>=20
> That's something we could fix in trunk.

yeah, i only brought it up because it was new code being proposed, and
no reason to have yet another undocumented place where this needed
to be fixed. =20

but, it seems from further info that the hash functions are used elsewhere =
in
the module in such a way that the parameter ends up treated as a uint no
matter what, so i don't think there's much to be done without tackling
the larger problem.  so, sorry for the noise :)


	sean

--T4sUOijqQbZv57TR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLqlRCynjLPm522B0RAnVXAJ0Q19jzM3kt2mtXbJEoECDFx7nj2wCfZ934
VDZCkTJsYgvNlXkMwpDM/CU=
=HmKU
-----END PGP SIGNATURE-----

--T4sUOijqQbZv57TR--