Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47569
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain openmv.com from 64.15.152.204 cause and error)
To: "'Lukas Kahwe Smith'" <mls@pooteeweet.org>,
	"'PHP Developers Mailing List'" <internals@lists.php.net>
References: <690D1362-7F1D-47B9-A4BF-EEA9CF38C5B0@pooteeweet.org>
In-Reply-To: <690D1362-7F1D-47B9-A4BF-EEA9CF38C5B0@pooteeweet.org>
Date: Wed, 24 Mar 2010 12:58:26 -0400
Message-ID: <001501cacb73$398c6420$aca52c60$@com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AcrLQJfi1ZbdCTeeQX+Udsu3kpiQfAAJmM+Q
Content-Language: en-ca
Subject: RE: [PHP-DEV] horizontal reuse: traits vs. grafts
From: jbondc@openmv.com ("Jonathan Bond-Caron")

On Wed Mar 24 06:50 AM, Lukas Kahwe Smith wrote:
> Ahoi,
> 
> Thought it would be better to open up a new thread and also using the 
> term "horizontal reuse" in the subject so that we make it clearer that 
> there are actually two approaches. Here is the URL for Stefan's
> proposal:
> http://wiki.php.net/rfc/horizontalreuse
> 

One thing I feel is missing from the RFC is how is_a() and instanceof are
affected with traits or grafts.

From:
http://github.com/gron/php-src/blob/PHP_5_3-traits/Zend/tests/traits/languag
e009.phpt

class Foo {
    use C, A, B {
	B::foo instead A, C;
    }
}

$f = new Foo;

echo is_a($f, 'A'); ?
echo is_a($f, 'B'); ?

It's seem to me that a defining a 'trait' should be advertised strictly as
an 'advanced multiple inheritance technique' to reuse pieces of code and it
shouldn't be considered as an object (grafts proposal).

I don't like the "B::foo instead A, C" stuff though, so I agree with Lukas
and find that Grafts are more intuitive / easy to learn.

Personally, this syntax makes me happy but would keep the 'use' or 'with'
keyword:
http://wiki.php.net/rfc/nonbreakabletraits

trait A {
   protected function foo() {
     echo 'a';
   }
}

trait D {
  public function foo() { echo "d"; }
  function bar() { echo "d"; }
}

class Foo {
    use A;
    use D {
      function bar();
    }
}

$f = new Foo;

echo is_a($f, 'A'); // true
echo is_a($f, 'D'); // false, since we've done an explicit
selection/brackets: use D {}

This is mainly userland feedback