Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47550
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=kFR3DNOur6PvJeKhj15KJnNIwumQxU0DPy76YJMETU7aS226Y9gq5IDwHfS9qKEYw+
         qvAui2OJfed4tnjyX4sfOMQNbKpmXEY9rmMdjoLiN+IqmZnGgVCcB9iWs67GovNMEsXA
         bcHCcRO5tHCAr6g06prgEtnxNmrNgB67pdUm0=
MIME-Version: 1.0
In-Reply-To: <20100324064852.GA11983@rangda.stickybit.se>
References: <4BA93A30.4040003@no-surprises.co.uk>
	 <20100323224105.GA9531@rangda.stickybit.se>
	 <4BA94C31.2020308@no-surprises.co.uk>
	 <20100324064852.GA11983@rangda.stickybit.se>
Date: Wed, 24 Mar 2010 10:26:45 +0100
Message-ID: <fe05d1541003240226n26369a5fvbeb6f0f4ccfbe4e1@mail.gmail.com>
To: sean finney <seanius@seanius.net>
Cc: Michael Maclean <michael@no-surprises.co.uk>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] FNV-1 support for ext/hash
From: pierre.php@gmail.com (Pierre Joye)

hi Sean,

On Wed, Mar 24, 2010 at 7:48 AM, sean finney <seanius@seanius.net> wrote:

> okay, so the hash module is generally broken for files > 2GB? =A0didn't
> know that. =A0i see update functions using both uint and size_t, but the
> function pointer signature uses uint so i doubt the hash results would
> be correct.

As far as I can tell that's not only for the hash module. Many areas
in php and its libraries rely on (u)int instead of size_t. It is or
was a common mistake. The problem is to change the signature now
without breaking ABI.

That's something we could fix in trunk.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org