Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47544
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain seanius.net from 66.93.22.232 cause and error)
Date: Wed, 24 Mar 2010 07:48:52 +0100
To: Michael Maclean <michael@no-surprises.co.uk>
Cc: internals@lists.php.net
Message-ID: <20100324064852.GA11983@rangda.stickybit.se>
References: <4BA93A30.4040003@no-surprises.co.uk>
 <20100323224105.GA9531@rangda.stickybit.se>
 <4BA94C31.2020308@no-surprises.co.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo"
Content-Disposition: inline
In-Reply-To: <4BA94C31.2020308@no-surprises.co.uk>
User-Agent: Mutt/1.5.20 (2009-06-14)
Subject: Re: [PHP-DEV] [PATCH] FNV-1 support for ext/hash
From: seanius@seanius.net (sean finney)

--envbJBWh7q8WU6mo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 23, 2010 at 11:18:09PM +0000, Michael Maclean wrote:
> >just to throw something out there, shouldn't the various inputLen
> >parameters be of type size_t instead of unsigned int?
>=20
> The function signature in php_hash.g says unsigned int, so that's
> what I used (though I note some of the other algorithms appear not
> to). We don't support files > 2^32 on 64-bit, so as I understand it,
> it's not going to cause issues right now, but if a large file
> support patch lands it's something that I might revisit.

okay, so the hash module is generally broken for files > 2GB?  didn't
know that.  i see update functions using both uint and size_t, but the
function pointer signature uses uint so i doubt the hash results would
be correct.

	sean

--envbJBWh7q8WU6mo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLqbXUynjLPm522B0RAhIkAJ94npmzIcE7QlieMy0VLq375R1a3gCfQB35
5Y1pHIGZhSgbYupyWYWUSQM=
=PkjO
-----END PGP SIGNATURE-----

--envbJBWh7q8WU6mo--