Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47535
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain no-surprises.co.uk designates 80.68.93.37 as permitted sender)
Message-ID: <4BA94C31.2020308@no-surprises.co.uk>
Date: Tue, 23 Mar 2010 23:18:09 +0000
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
MIME-Version: 1.0
To: sean finney <seanius@seanius.net>
CC: internals@lists.php.net
References: <4BA93A30.4040003@no-surprises.co.uk> <20100323224105.GA9531@rangda.stickybit.se>
In-Reply-To: <20100323224105.GA9531@rangda.stickybit.se>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] FNV-1 support for ext/hash
From: michael@no-surprises.co.uk (Michael Maclean)

sean finney wrote:
> On Tue, Mar 23, 2010 at 10:01:20PM +0000, Michael Maclean wrote:
>> The patch:
>> http://mgdm.net/~michael/patches/php-fnv.txt
> 
> just to throw something out there, shouldn't the various inputLen 
> parameters be of type size_t instead of unsigned int?

The function signature in php_hash.g says unsigned int, so that's what I 
used (though I note some of the other algorithms appear not to). We 
don't support files > 2^32 on 64-bit, so as I understand it, it's not 
going to cause issues right now, but if a large file support patch lands 
it's something that I might revisit.

-- 
Cheers,
Michael