Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47531 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 80119 invoked from network); 23 Mar 2010 22:41:15 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Mar 2010 22:41:15 -0000 Authentication-Results: pb1.pair.com smtp.mail=sean@seanius.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=seanius@seanius.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain seanius.net from 66.93.22.232 cause and error) X-PHP-List-Original-Sender: sean@seanius.net X-Host-Fingerprint: 66.93.22.232 cobija.connexer.com Received: from [66.93.22.232] ([66.93.22.232:51704] helo=cobija.connexer.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B3/50-12746-88349AB4 for ; Tue, 23 Mar 2010 17:41:14 -0500 Received: from rangda.stickybit.se (h-234-204.A189.priv.bahnhof.se [81.170.234.204]) by cobija.connexer.com (Postfix) with ESMTPA id A3B2630170; Tue, 23 Mar 2010 18:41:08 -0400 (EDT) Received: by rangda.stickybit.se (Postfix, from userid 1000) id 2B26B104BF; Tue, 23 Mar 2010 23:41:06 +0100 (CET) Date: Tue, 23 Mar 2010 23:41:06 +0100 To: Michael Maclean Cc: internals@lists.php.net Message-ID: <20100323224105.GA9531@rangda.stickybit.se> References: <4BA93A30.4040003@no-surprises.co.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: <4BA93A30.4040003@no-surprises.co.uk> User-Agent: Mutt/1.5.20 (2009-06-14) Subject: Re: [PHP-DEV] [PATCH] FNV-1 support for ext/hash From: seanius@seanius.net (sean finney) --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 23, 2010 at 10:01:20PM +0000, Michael Maclean wrote: > The patch: > http://mgdm.net/~michael/patches/php-fnv.txt just to throw something out there, shouldn't the various inputLen=20 parameters be of type size_t instead of unsigned int? sean --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFLqUOBynjLPm522B0RAs9nAKCCbTP4Z5aNbKJhq4As8JM/b851tACgiRtR spljdiOJH67fCCvJxU5Qwrk= =8AmK -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--