Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47501
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=GwNDj0bOcj6k7I2EuL8F4kWT4BT6PZl6ma33VADWGnsGmWheeuWvVX+9aCV0aGxAQM
         DyefcTUuIl2PJjuBI5wKRnGQL3byimjxYgIBBlEJEOnZyEnzX/H/rtESY7hMIXpDzUWI
         /7iHI3fmR5h3MWlnZqb/39Cgk0+G53RhFrH5Y=
MIME-Version: 1.0
In-Reply-To: <4BA8F985.1090109@daylessday.org>
References: <4BA8EF6F.8010503@daylessday.org> <4BA8F72E.5090701@sci.fi>
	 <4BA8F985.1090109@daylessday.org>
Date: Tue, 23 Mar 2010 20:37:45 +0100
Message-ID: <fe05d1541003231237v31a86f24wd84c75d69381f4a3@mail.gmail.com>
To: Antony Dovgal <tony@daylessday.org>
Cc: jani.taskinen@iki.fi, php-dev <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] FPM RFC
From: pierre.php@gmail.com (Pierre Joye)

hi Tony,

On Tue, Mar 23, 2010 at 6:25 PM, Antony Dovgal <tony@daylessday.org> wrote:

>> Does it really need to be separate SAPI? I mean, just replace the old sapi/cgi
>> with it? Keep the name 'cgi' though. :)
>
> I don't see any need to touch sapi/cgi at all.
> Keeping both CGI and FastCGI in one SAPI leads to a nasty code mess with lots of
> "if (fcgi_is_fastcgi()) {" as you can now see in cgi_main.c.

Not sure to follow, are you suggesting to consider FPM as the
sapi/cgi's fastcgi replacement? As Jani is suggesting.

> sapi/fpm and sapi/cgi now have quite different codebase as we've dropped some stuff
> not pertinent to FastCGI (there might be some leftovers, I'll deal with them later).

By the way, how portable is it? I don't think it has been tested on
windows (some of the key features are not necessary with IIS/FCGI as
they do it already but could be for other web servers).

I would suggest to keep it as a separate sapi for now, or forever if it works.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org