Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47465 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99311 invoked from network); 22 Mar 2010 18:10:06 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Mar 2010 18:10:06 -0000 Authentication-Results: pb1.pair.com header.from=scott@macvicar.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=scott@macvicar.net; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain macvicar.net from 97.107.131.220 cause and error) X-PHP-List-Original-Sender: scott@macvicar.net X-Host-Fingerprint: 97.107.131.220 whisky.macvicar.net Linux 2.6 Received: from [97.107.131.220] ([97.107.131.220:47111] helo=whisky.macvicar.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 41/B3-15234-C72B7AB4 for ; Mon, 22 Mar 2010 13:10:05 -0500 Received: from [172.24.135.30] (out1-1601fw.corp.tfbnw.net [66.220.144.27]) by whisky.macvicar.net (Postfix) with ESMTP id 31D3146A51; Mon, 22 Mar 2010 14:10:02 -0400 (EDT) Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii In-Reply-To: <98b8086f1003221054j161316barf9a772da78f4ca85@mail.gmail.com> Date: Mon, 22 Mar 2010 11:10:00 -0700 Cc: Herman Radtke , PHP Developers Mailing List Content-Transfer-Encoding: quoted-printable Message-ID: <1855ED34-B6FA-4B74-B603-5A0D0A47A5A6@macvicar.net> References: <98b8086f1003220751j73a8414es89b9b469c46f6630@mail.gmail.com> <1269270852.1575.141.camel@guybrush> <98b8086f1003220822s47665f87x696b70e9c13dadbd@mail.gmail.com> <98b8086f1003220855ya52c266g8dc4cb866ed451ea@mail.gmail.com> <98b8086f1003221054j161316barf9a772da78f4ca85@mail.gmail.com> To: troels knak-nielsen X-Mailer: Apple Mail (2.1077) Subject: Re: [PHP-DEV] [PATCH] Raise warning first on "Maximum execution time exceeded" From: scott@macvicar.net (Scott MacVicar) On Mar 22, 2010, at 10:55 AM, troels knak-nielsen wrote: > On Mon, Mar 22, 2010 at 4:55 PM, troels knak-nielsen = wrote: >> On Mon, Mar 22, 2010 at 4:41 PM, Herman Radtke = wrote: >>>> What do you mean by "no option"? Otherwise yes, that's what it = does. >>> Using sleep there is not a good practice. Since the custom error >>> handler is triggered, there is no need for the sleep call anyways. >>=20 >> So control isn't returned to the C-code before the php error handler >> finishes. Is that it? >=20 > Just checked, and you're right about this. I've made a new patch, > which addresses this. Again, I have no idea about whether I'm > violating code style (Should zend_timeout_softswitch be declared or > named differently?), so comments on that please? >=20 > New patch attached - disregard the previous one. >=20 Statics are bad, if its in multithreaded mode and two timeouts happen at = once you'll get some funny behaviour. You need to store this in the = thread local storage so the flag is per thread. Scott=