Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47464 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 96393 invoked from network); 22 Mar 2010 17:55:07 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Mar 2010 17:55:07 -0000 Authentication-Results: pb1.pair.com header.from=troelskn@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=troelskn@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.216 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: troelskn@gmail.com X-Host-Fingerprint: 209.85.218.216 mail-bw0-f216.google.com Received: from [209.85.218.216] ([209.85.218.216:33864] helo=mail-bw0-f216.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 64/13-15234-9FEA7AB4 for ; Mon, 22 Mar 2010 12:55:07 -0500 Received: by bwz8 with SMTP id 8so419525bwz.23 for ; Mon, 22 Mar 2010 10:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=aHBFihBK++p8kpJGnwdZ3Gn5rjlNUCtryDp3LJw6kuU=; b=Hi75b8cyksZsk1REXl3GIcSUtsfuHO7MGzKu9ih4/GRfi+QAGe4a+EigvsrQXBARoN S1Zk/MhH5v70C9eTUmMw+wuhSguhPtZ00X3a92CGHET1RLfvWtB37R0dRmuP6PXvS/D4 LIHDkFJy7lkXZBItGU4fnJMtic0bkoHsiZ+L4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=HJ9XA99oCCqr2tJq2LLQXqCoiH4dlvPnBbHCqX6xILY1gWP8IVHTOy5ADDyicoixk3 a7A+/tDeHYhmN+NXvPt6GRv0gVr98uFLe/EH/0dmHlpzVTzSLU0CKNgVIglJFeWBvyGg g7WKq5o9FlpsHspAfu+WzT2vOtfX85Nuu+dQ4= MIME-Version: 1.0 Received: by 10.204.5.217 with SMTP id 25mr3703901bkw.114.1269280501951; Mon, 22 Mar 2010 10:55:01 -0700 (PDT) In-Reply-To: <98b8086f1003220855ya52c266g8dc4cb866ed451ea@mail.gmail.com> References: <98b8086f1003220751j73a8414es89b9b469c46f6630@mail.gmail.com> <1269270852.1575.141.camel@guybrush> <98b8086f1003220822s47665f87x696b70e9c13dadbd@mail.gmail.com> <98b8086f1003220855ya52c266g8dc4cb866ed451ea@mail.gmail.com> Date: Mon, 22 Mar 2010 18:55:00 +0100 Message-ID: <98b8086f1003221054j161316barf9a772da78f4ca85@mail.gmail.com> To: Herman Radtke Cc: PHP Developers Mailing List Content-Type: multipart/mixed; boundary=001517588ca4709ed0048267650a Subject: Re: [PHP-DEV] [PATCH] Raise warning first on "Maximum execution time exceeded" From: troelskn@gmail.com (troels knak-nielsen) --001517588ca4709ed0048267650a Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Mon, Mar 22, 2010 at 4:55 PM, troels knak-nielsen w= rote: > On Mon, Mar 22, 2010 at 4:41 PM, Herman Radtke w= rote: >>> What do you mean by "no option"? Otherwise yes, that's what it does. >> Using sleep there is not a good practice. =A0Since the custom error >> handler is triggered, there is no need for the sleep call anyways. > > So control isn't returned to the C-code before the php error handler > finishes. Is that it? Just checked, and you're right about this. I've made a new patch, which addresses this. Again, I have no idea about whether I'm violating code style (Should zend_timeout_softswitch be declared or named differently?), so comments on that please? New patch attached - disregard the previous one. --=20 troels --001517588ca4709ed0048267650a Content-Type: text/x-diff; charset=US-ASCII; name="zend_timeout_warning_2.patch" Content-Disposition: attachment; filename="zend_timeout_warning_2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g73ktflf0 LS0tIC4vWmVuZC96ZW5kX2V4ZWN1dGVfQVBJLmMub3JpZwkyMDEwLTAzLTIyIDE1OjMzOjE3LjAw MDAwMDAwMCArMDEwMAorKysgLi9aZW5kL3plbmRfZXhlY3V0ZV9BUEkuYwkyMDEwLTAzLTIyIDE4 OjQ1OjA4LjAwMDAwMDAwMCArMDEwMApAQCAtMTMwMCwxOCArMTMwMCwyNiBAQAogfQogLyogfX19 ICovCiAKK3N0YXRpYyBpbnQgemVuZF90aW1lb3V0X3NvZnRzd2l0Y2ggPSAwOworCiBaRU5EX0FQ SSB2b2lkIHplbmRfdGltZW91dChpbnQgZHVtbXkpIC8qIHt7eyAqLwogewotCVRTUk1MU19GRVRD SCgpOwotCi0JaWYgKHplbmRfb25fdGltZW91dCkgewotCQl6ZW5kX29uX3RpbWVvdXQoRUcodGlt ZW91dF9zZWNvbmRzKSBUU1JNTFNfQ0MpOworCWlmICh6ZW5kX3RpbWVvdXRfc29mdHN3aXRjaCA9 PSAwKSB7CisJCXplbmRfdGltZW91dF9zb2Z0c3dpdGNoID0gMTsKKwkJemVuZF91bnNldF90aW1l b3V0KFRTUk1MU19DKTsKKwkJemVuZF9zZXRfdGltZW91dCgxLCAxKTsKKwkJemVuZF9lcnJvcihF X1dBUk5JTkcsICJNYXhpbXVtIGV4ZWN1dGlvbiB0aW1lIG9mICVkIHNlY29uZCVzIGV4Y2VlZGVk IiwgRUcodGltZW91dF9zZWNvbmRzKSwgRUcodGltZW91dF9zZWNvbmRzKSA9PSAxID8gIiIgOiAi cyIpOworCX0gZWxzZSB7CisJCVRTUk1MU19GRVRDSCgpOworIAorCQlpZiAoemVuZF9vbl90aW1l b3V0KSB7CisJCQl6ZW5kX29uX3RpbWVvdXQoRUcodGltZW91dF9zZWNvbmRzKSBUU1JNTFNfQ0Mp OworCQl9CisgCisJCXplbmRfZXJyb3IoRV9FUlJPUiwgIk1heGltdW0gZXhlY3V0aW9uIHRpbWUg b2YgJWQgc2Vjb25kJXMgZXhjZWVkZWQiLCBFRyh0aW1lb3V0X3NlY29uZHMpLCBFRyh0aW1lb3V0 X3NlY29uZHMpID09IDEgPyAiIiA6ICJzIik7CiAJfQotCi0JemVuZF9lcnJvcihFX0VSUk9SLCAi TWF4aW11bSBleGVjdXRpb24gdGltZSBvZiAlZCBzZWNvbmQlcyBleGNlZWRlZCIsIEVHKHRpbWVv dXRfc2Vjb25kcyksIEVHKHRpbWVvdXRfc2Vjb25kcykgPT0gMSA/ICIiIDogInMiKTsKIH0KLS8q IH19fSAqLwotCisgLyogfX19ICovCiAjaWZkZWYgWkVORF9XSU4zMgogc3RhdGljIExSRVNVTFQg Q0FMTEJBQ0sgemVuZF90aW1lb3V0X1duZFByb2MoSFdORCBoV25kLCBVSU5UIG1lc3NhZ2UsIFdQ QVJBTSB3UGFyYW0sIExQQVJBTSBsUGFyYW0pIC8qIHt7eyAqLwogewo= --001517588ca4709ed0048267650a--