Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47418
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.170 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=vArRJA9IAcnclgh+y44tgWhg2t2e4+sS2TCOZ5r6CIp0N4OzqS2P3wGtHIhukGKe6h
         H7b6yXCnDWCOdhYKgks01KhhPnHd6CVCiembamgAIvnNSFgKZF1KEGp8lOVMuJH4rP9s
         VNqWW5OAwA4YcbVspRfMshMzhldj2EH42RuFk=
MIME-Version: 1.0
In-Reply-To: <fe05d1541003181537w708e891aj82d828ec13d32314@mail.gmail.com>
References: <fe05d1541003181537w708e891aj82d828ec13d32314@mail.gmail.com>
Date: Fri, 19 Mar 2010 00:04:41 +0100
Message-ID: <fe05d1541003181604q667eb2cfu539b5fbdb9688b59@mail.gmail.com>
To: Andrei Zmievski <andrei@php.net>, PHP internals <internals@lists.php.net>, 
	Ilia Alshanetsky <ilia@prohost.org>, =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@schlueters.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-CVS] svn: /php/php-src/branches/ PHP_5_2/configure.in 
	PHP_5_2/ext/standard/file.c PHP_5_2/main/SAPI.c PHP_5_2/main/SAPI.h 
	PHP_5_2/main/rfc1867.c PHP_5_3/configure.in PHP_5_3/ext/standard/file.c 
	PHP_5_3/main/SAPI.c PHP_5_3/main/SAPI.h PHP_5_3
From: pierre.php@gmail.com (Pierre Joye)

Issue solved, the patch has been reverted by Andrei, thanks.

However the question about the bad new configure option remains.

On Thu, Mar 18, 2010 at 11:37 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> hi,
>
> CCing Ilia and Johannes as Andrei "discussed with the RM offline", I
> suppose it is Ilia, but Johannes is the 5.3 RM.
>
> For the record, this fix is about using size_t in the SAPI to fix
> issues with uploaded files > 2G.
>
> While wondering what was the reasoning behind this commit, I came to
> the conclusion that we should not do such thing in stable branches and
> we should respect something we decided long time ago, to stop to add
> bad options which can break PHP ABI or BC in one way or another. It is
> especially important as we all know how distributors tend to deal with
> such options.
>
> The other reasons why I would like to revert this commit are:
> - not sure there are so many people uploading 2G+ files
> - 5.2 should really be in security fixes mode only
> - 5.3 should be in bug fixing mode only (without ABI breaks, even optiona=
l :)
>
> Opinions?
>
> Cheers,
>
> On Thu, Mar 18, 2010 at 10:07 PM, Andrei Zmievski <andrei@php.net> wrote:
>> andrei =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 Thu, 18 Mar 2010 21:07:38 +0000
>>
>> Revision: http://svn.php.net/viewvc?view=3Drevision&revision=3D296358
>>
>> Log:
>> Fix a few problems with large (2G-4G) file uploads. Added
>> --enable-large-uploads-fix switch because one change was in SAPI.h struc=
ture.
>>
>> Changed paths:
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_2/configure.in
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_2/ext/standard/file.c
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_2/main/SAPI.c
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_2/main/SAPI.h
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_2/main/rfc1867.c
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/configure.in
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/ext/standard/file.c
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/main/SAPI.c
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/main/SAPI.h
>> =A0 =A0U =A0 php/php-src/branches/PHP_5_3/main/rfc1867.c
>>
>>
>> --
>> PHP CVS Mailing List (http://www.php.net/)
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org