Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47210 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 56822 invoked from network); 13 Mar 2010 03:07:04 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Mar 2010 03:07:04 -0000 Authentication-Results: pb1.pair.com header.from=listas@rafaeldohms.com.br; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=listas@rafaeldohms.com.br; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain rafaeldohms.com.br from 209.85.211.177 cause and error) X-PHP-List-Original-Sender: listas@rafaeldohms.com.br X-Host-Fingerprint: 209.85.211.177 mail-yw0-f177.google.com Received: from [209.85.211.177] ([209.85.211.177:37731] helo=mail-yw0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 67/63-13686-6510B9B4 for ; Fri, 12 Mar 2010 22:07:03 -0500 Received: by ywh7 with SMTP id 7so798496ywh.26 for ; Fri, 12 Mar 2010 19:07:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.101.141.29 with SMTP id t29mr355473ann.3.1268449620108; Fri, 12 Mar 2010 19:07:00 -0800 (PST) In-Reply-To: References: <4B9926E8.4080202@lerdorf.com> <4B9AB840.1010209@zend.com> <4B9ABDCE.2070904@zend.com> <4B9AC13B.401@sci.fi> <4B9ACDF8.2020300@zend.com> Date: Sat, 13 Mar 2010 00:07:00 -0300 Message-ID: <33cd61491003121907o2fcb053ct21ea9e821b27e254@mail.gmail.com> To: Pierre Joye Cc: Stanislav Malyshev , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Tests repository From: listas@rafaeldohms.com.br (Rafael Dohms) On Fri, Mar 12, 2010 at 9:52 PM, Pierre Joye wrote > On Sat, Mar 13, 2010 at 12:27 AM, Stanislav Malyshev wrote: >> Hi! >> It is possible, but that means instead of 2 trees of files you'd have these >> trees distributed inside test files in a myriad of small if()s: >> if(version == X) { test this error message } >> elseif(version == Y) { test that error message } >> else { test that another error message } >> >> and the same for different pieces of function, etc. Why is it better? > > I'm not saying it is better to write test, but it is better to > maintain one set of tests for all branches and keep them uptodate. But > that's definitivelly more work, and not only for the 1st shot. That's > why I would rather triple check if we really want to go down this way. One thing to notice is change in output between versions. During testfest we wrote various tests and tried to make them as generic as possible to run in 5.2/5.3/6. It worked in mosts tests but some suttle differences would make it a pain to write a unified test. For example: When writing the tests for trunk "string" became "unicode" Whatever path PHP6 does go down, we need to rememebr small changes like this can come along in other aspects So just a version check for the test is not all that's needed, we need something to deal with these differences as well. -- Rafael Dohms PHP Evangelist and Community Leader http://www.rafaeldohms.com.br http://www.phpsp.org.br