Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47203
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=nRnVthFTtVbuP1lnqgFMLdNW7/iBGUjSDxob10HMucuAYdMhzb9iIWfoOp9DIULKMJ
         z22gA4pYmlmzr4EP54/X1Y8KB7AUYct5/NnuZEK99ttnPW4LwS328uhdyE4Lk63ZLiGR
         DpQ04P/J6fytm0UNHXs0IiwrpOsuNL0HPtO/A=
MIME-Version: 1.0
In-Reply-To: <4B9ACDF8.2020300@zend.com>
References: <4B9926E8.4080202@lerdorf.com>
	 <1418253B-84A3-4CA6-965B-A2501A5D432F@gmail.com>
	 <4B9AB840.1010209@zend.com>
	 <ce6b011c1003121413p4b9fbff9qa79af5ee0db0778@mail.gmail.com>
	 <4B9ABDCE.2070904@zend.com> <4B9AC13B.401@sci.fi>
	 <fe05d1541003121439y60838573j5206d41c238d0431@mail.gmail.com>
	 <ce6b011c1003121504g7eb006dt4bca9716e7c6a848@mail.gmail.com>
	 <fe05d1541003121514q662b4e6cvbe50eaf830e40254@mail.gmail.com>
	 <4B9ACDF8.2020300@zend.com>
Date: Sat, 13 Mar 2010 01:52:37 +0100
Message-ID: <fe05d1541003121652p75b8b668p77a88a357132ea83@mail.gmail.com>
To: Stanislav Malyshev <stas@zend.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Tests repository
From: pierre.php@gmail.com (Pierre Joye)

On Sat, Mar 13, 2010 at 12:27 AM, Stanislav Malyshev <stas@zend.com> wrote:
> Hi!
>
>> It is always possible to write a test for both versions (except
>> namespace). However it requires a radical change on how we test
>> things.
>> Instead of testing the output of given script, we will have to add
>> logics in a test, something similar to the classic xUnit frameworks.
>> For example, we will have to do the error msg check inside the test
>
> It is possible, but that means instead of 2 trees of files you'd have these
> trees distributed inside test files in a myriad of small if()s:
> if(version == X) { test this error message }
> elseif(version == Y) { test that error message }
> else { test that another error message }
>
> and the same for different pieces of function, etc. Why is it better?

I'm not saying it is better to write test, but it is better to
maintain one set of tests for all branches and keep them uptodate. But
that's definitivelly more work, and not only for the 1st shot. That's
why I would rather triple check if we really want to go down this way.

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org