Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47202
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.223.177 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=C7N8SOUzOxnaCjLOJAZQKz5fE4AUR/ROjsq8nqcVhDoGxmf7z6JOg+i8kkAqtgdGku
         K1TIEV59peKSOluzbLnaa2nFQoqRT5SuqYFJj1ghXimHFekIVHoCsvA9a3skj4G5K3Ew
         A4AJbP4cLaBcHqqm2TGzoK9TLV/UMKzy5PRQw=
MIME-Version: 1.0
In-Reply-To: <4B9ACDF8.2020300@zend.com>
References: <4B9926E8.4080202@lerdorf.com>
	 <1418253B-84A3-4CA6-965B-A2501A5D432F@gmail.com>
	 <4B9AB840.1010209@zend.com>
	 <ce6b011c1003121413p4b9fbff9qa79af5ee0db0778@mail.gmail.com>
	 <4B9ABDCE.2070904@zend.com> <4B9AC13B.401@sci.fi>
	 <fe05d1541003121439y60838573j5206d41c238d0431@mail.gmail.com>
	 <ce6b011c1003121504g7eb006dt4bca9716e7c6a848@mail.gmail.com>
	 <fe05d1541003121514q662b4e6cvbe50eaf830e40254@mail.gmail.com>
	 <4B9ACDF8.2020300@zend.com>
Date: Fri, 12 Mar 2010 18:53:49 -0500
Message-ID: <ce6b011c1003121553o7ca27db5o288f0b3db7cbac14@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=0050450144a62569280481a33e0a
Subject: Re: [PHP-DEV] Tests repository
From: ericleestewart@gmail.com (Eric Stewart)

--0050450144a62569280481a33e0a
Content-Type: text/plain; charset=ISO-8859-1

On Fri, Mar 12, 2010 at 6:27 PM, Stanislav Malyshev <stas@zend.com> wrote:

> Hi!
>
>
>  It is always possible to write a test for both versions (except
>> namespace). However it requires a radical change on how we test
>> things.
>> Instead of testing the output of given script, we will have to add
>> logics in a test, something similar to the classic xUnit frameworks.
>> For example, we will have to do the error msg check inside the test
>>
>
> It is possible, but that means instead of 2 trees of files you'd have these
> trees distributed inside test files in a myriad of small if()s:
> if(version == X) { test this error message }
> elseif(version == Y) { test that error message }
> else { test that another error message }
>
> and the same for different pieces of function, etc. Why is it better?
>
> --
> Stanislav Malyshev, Zend Software Architect
> stas@zend.com   http://www.zend.com/
> (408)253-8829   MSN: stas@zend.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
There are going to be differences, that's a given and I don't dispute that.

If I'm given the choice of those differences being in one file or in three
different files (5.2, 5.3, 6.0)? I choose one file. Even if that files is
more complex. It's still one file. One commit. One place to look for
problems. And you get the bonus of being able to see the actual differences
of the same functionality in different versions of PHP all in one place.

So yes, I do think that is better.

Eric Lee Stewart

--0050450144a62569280481a33e0a--