Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47195 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 89873 invoked from network); 12 Mar 2010 22:33:34 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Mar 2010 22:33:34 -0000 Authentication-Results: pb1.pair.com smtp.mail=jani.taskinen@sci.fi; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=jani.taskinen@sci.fi; sender-id=unknown Received-SPF: error (pb1.pair.com: domain sci.fi from 204.13.248.72 cause and error) X-PHP-List-Original-Sender: jani.taskinen@sci.fi X-Host-Fingerprint: 204.13.248.72 mho-02-ewr.mailhop.org Received: from [204.13.248.72] ([204.13.248.72:63236] helo=mho-02-ewr.mailhop.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 65/C6-13686-D31CA9B4 for ; Fri, 12 Mar 2010 17:33:34 -0500 Received: from cs27025051.pp.htv.fi ([89.27.25.51] helo=[127.0.0.1]) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:CAMELLIA256-SHA:256) (Exim 4.68) (envelope-from ) id 1NqDQA-0007ck-U3; Fri, 12 Mar 2010 22:33:31 +0000 X-Mail-Handler: MailHop Outbound by DynDNS X-Originating-IP: 89.27.25.51 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/mailhop/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX19eTcurNCsjZYBgN6E9vKbsou9/lUhtXbs= Message-ID: <4B9AC13B.401@sci.fi> Date: Sat, 13 Mar 2010 00:33:31 +0200 Reply-To: jani.taskinen@iki.fi User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; fi; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: Stanislav Malyshev CC: internals@lists.php.net References: <4B9926E8.4080202@lerdorf.com> <4B997381.1050300@oracle.com> <4B9A14FF.6000703@iki.fi> <4B9A833A.8040402@zend.com> <4B9A848C.3080701@iki.fi> <4B9A93EE.7080403@zend.com> <1418253B-84A3-4CA6-965B-A2501A5D432F@gmail.com> <4B9AB840.1010209@zend.com> <4B9ABDCE.2070904@zend.com> In-Reply-To: <4B9ABDCE.2070904@zend.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Tests repository From: jani.taskinen@sci.fi (Jani Taskinen) 13.3.2010 0:18, Stanislav Malyshev wrote: > Hi! > >> There are going to be some technical challenges. Some (maybe a lot) of >> test >> will need updates or rewriting. run-tests.php may need more improvements >> than what is already planned. Knowing this, I would still rather update >> run-tests.php and fix the tests, then continue to applying tests to >> different branches of the code base. > > I still have yet to hear *how* these tests are supposed to be updated, > to work everywhere. It's very easy to say "oh, we'll just fix them" - > but how exactly you're going to fix them if the test is supposed to do > one thing in 5.2 and another in 5.3? Are you going to have 2 versions of What tests are you really talking about here? I thought we have regression tests in there which test that stuff does not change between versions. Such test AFAICT help us to keep stuff to work like it worked before and after some change somewhere in the related code. So there should not be any need for any updates given the tests aren't for some reason different between branches in which case they aren't really the same test anymore. Short version: if test works in 5.2 it also has to (!) work in 5.3. Otherwise the test is pointless. Can you define the case you're referring to here or are we actually talking about totally different thing? --Jani