Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47190 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 60292 invoked from network); 12 Mar 2010 19:40:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Mar 2010 19:40:57 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 74.125.82.42 mail-ww0-f42.google.com Received: from [74.125.82.42] ([74.125.82.42:49581] helo=mail-ww0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 24/81-13686-8C89A9B4 for ; Fri, 12 Mar 2010 14:40:57 -0500 Received: by wwc33 with SMTP id 33so1089950wwc.29 for ; Fri, 12 Mar 2010 11:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=CiDsyt+BaecUw0wFrWDUS5SPC3swjXmP6QZmmEYccOA=; b=wStytxsKDJs/hwQ2TLWJt52nULJjGQwiZpL75hw8DYEttucMJZnRIJ7XS/fx8Fda6Z b77jGuAumoFArwt65dbi0B85bBBGoArWYR0hbNfink69vm9HXIzOVQh0jqQm4Z3S9tgL +dhNM2rRDY2qvaszEjTg7iTxZQssj+uNPX6TI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=k/+I7bxMLI39FcxhoQb+GYydPHtGakCR3UPdGaLwKIlcRovWh/V/5DMSnteE+gbq4v keFs91gLx8NxqjYk0J3cK3H3hW8eLGMRzRvz+xgnepAsxaAYSyBuDGCT4pWX2d4cJbMo MFgE1h4HXsGVhQ11T2/+uPOPaE6D622hYcQ0g= MIME-Version: 1.0 Received: by 10.216.85.132 with SMTP id u4mr893592wee.191.1268422853345; Fri, 12 Mar 2010 11:40:53 -0800 (PST) In-Reply-To: <84A2AA1E-3E1F-49E6-85ED-B0E4BA13A731@gmail.com> References: <4B9926E8.4080202@lerdorf.com> <4B996FC6.7040102@zend.com> <4B997381.1050300@oracle.com> <4B9A14FF.6000703@iki.fi> <4B9A833A.8040402@zend.com> <4B9A848C.3080701@iki.fi> <84A2AA1E-3E1F-49E6-85ED-B0E4BA13A731@gmail.com> Date: Fri, 12 Mar 2010 20:40:53 +0100 Message-ID: To: Alexey Zakhlestin Cc: jani.taskinen@iki.fi, Stanislav Malyshev , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Tests repository From: pierre.php@gmail.com (Pierre Joye) On Fri, Mar 12, 2010 at 8:39 PM, Alexey Zakhlestin wro= te: > > On 12.03.2010, at 22:23, Pierre Joye wrote: > >> On Fri, Mar 12, 2010 at 8:10 PM, Alexey Zakhlestin = wrote: >>> >>> On 12.03.2010, at 22:06, Pierre Joye wrote: >>> >>>> Many tests fail because they are written for a given platform, or even >>>> worst (from a portability point of view), only for a given >>>> configuration (library version, system version,etc.). And that's not >>>> about windows vs other, tests can work on a Debian/ubuntu version and >>>> fail on another. >>> >>> Well, these tests should just be removed/rewritten. >>> Php-tests should test php, not libraries >> >> I would be interested to know how can we test the file API without >> testing libc, for example. > > see my reply to Stas. > > The idea is to test things which we can guarantee. If our documentation s= ays, that function does this or that, then we should check for it and wrap = system-calls in such way, that our "file API" always does these things or f= ails in strict predictable manner. > And if we can't guarantee some behaviour then we should add corresponding= note to documentation and we shouldn't add tests. That's exactly (for part of the needs) what I describe in the 2nd part of my reply. --=20 Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org