Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47062
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.216 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=WBmFea6fTvXEsgW8a1GBBvZIFZu6iwl+B3nHo9N313CUEmCQau4uFC6mKCBuh9XNvx
         89YZQ1UEazrbfRkK000odmaF+VGmyOCYtwqiF6HPNkLVDmJbs5Cby51mQNmLSHZJ4n7C
         C/7JIrarHUyxIm9JcqEFkhwblgn0EBQ7wAOUY=
MIME-Version: 1.0
In-Reply-To: <4B8A97AF.3060608@seld.be>
References: <4B8A97AF.3060608@seld.be>
Date: Sun, 28 Feb 2010 11:03:06 -0800
Message-ID: <f658eb6f1002281103k28973951xe3ba6512ee8350fe@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Unserialize is broken
From: hermanradtke@gmail.com (Herman Radtke)

> Imo unserialize should check, when applying public or protected values,
> if either exists on the object, and apply it to the one that exists.
> Sure it's gonna cost some performance, but at least changing the
> prototype of your class while stuff is running isn't going to kill your
> code anymore.

This seems like a corner case and one that a conversion script should
handle.  Considering that serialize and unserialize are called for
every single web-request, degrading the performance of unserialize is
not something that should be done lightly.



-- 
Herman Radtke
hermanradtke@gmail.com | http://hermanradtke.com