Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47034
Return-Path: <geissert@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 69819 invoked from network); 23 Feb 2010 01:11:15 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 23 Feb 2010 01:11:15 -0000
X-Host-Fingerprint: 200.66.18.213 unknown  
Received: from [200.66.18.213] ([200.66.18.213:11514] helo=localhost.localdomain)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 0D/F0-00376-23B238B4 for <internals@lists.php.net>; Mon, 22 Feb 2010 20:11:15 -0500
Message-ID: <0D.F0.00376.23B238B4@pb1.pair.com>
To: internals@lists.php.net
Followup-To: php.internals
Lines: 11
Date: Mon, 22 Feb 2010 19:09:40 -0600
References: <B1.A2.00376.BEC618B4@pb1.pair.com> <7B.19.00376.96CD18B4@pb1.pair.com> <fe05d1541002220023i27d21f2boae9d5d2720345095@mail.gmail.com> <alpine.DEB.2.00.1002221401360.24578@kossu.derickrethans.nl> <05.0C.00376.39F038B4@pb1.pair.com> <alpine.DEB.2.00.1002230052560.24578@kossu.derickrethans.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7Bit
X-Posted-By: 200.66.18.213
Subject: Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?
From: geissert@php.net (Raphael Geissert)

Derick Rethans wrote:

> What exactly are you trying to fix here?
> 

gcc 4.4's optimiser removes the overflow check present in 
php_filter_parse_int and ZEND_HANDLE_NUMERIC (but I can't touch that part of 
the code anyway...) which prevents the overflow from being detected.

Cheers,
-- 
Raphael Geissert