Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47033 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 65097 invoked from network); 23 Feb 2010 00:53:13 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Feb 2010 00:53:13 -0000 Authentication-Results: pb1.pair.com header.from=derick@php.net; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=derick@php.net; spf=unknown; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 82.113.146.227 as permitted sender) X-PHP-List-Original-Sender: derick@php.net X-Host-Fingerprint: 82.113.146.227 xdebug.org Linux 2.6 Received: from [82.113.146.227] ([82.113.146.227:33934] helo=xdebug.org) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 81/10-00376-8F6238B4 for ; Mon, 22 Feb 2010 19:53:12 -0500 Received: from localhost (xdebug.org [127.0.0.1]) by xdebug.org (Postfix) with ESMTPS id B36F2E2031; Tue, 23 Feb 2010 00:53:08 +0000 (UTC) Date: Tue, 23 Feb 2010 00:53:08 +0000 (GMT) X-X-Sender: derick@kossu.derickrethans.nl To: Raphael Geissert cc: internals@lists.php.net In-Reply-To: <05.0C.00376.39F038B4@pb1.pair.com> Message-ID: References: <7B.19.00376.96CD18B4@pb1.pair.com> <05.0C.00376.39F038B4@pb1.pair.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}? From: derick@php.net (Derick Rethans) On Mon, 22 Feb 2010, Raphael Geissert wrote: > Derick Rethans wrote: > > On Mon, 22 Feb 2010, Pierre Joye wrote: > >> Please don't commit this change. I remember some issues with strtol > >> (portability, BC breaks, etc.). Please wait until we figured them out, > >> or find back in the archives why strtol could be a bad idea. > > > > Poratability was indeed the reason, as well as the locale issues that > > you mention (POSIX locales==useless). Please don't commit this. > > > > Ok. Sean came up with a different patch which is being tested right now. > If all the tests pass then I'm going to commit it. What exactly are you trying to fix here? Derick -- http://derickrethans.nl | http://xdebug.org twitter: @derickr