Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47032
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.78.26 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=vqYcxP/A1PsrDflaGgXdos//Yy4M1oSCu6tr9GcyRtnlleONbg/RRefcaxQBDanGpl
         cSYZBD5fdMFbfAO6qAd2T2jhQCQUq2WU+pBhRL+G3atYda9wmuP3Mqtc0QUpPj6hupwt
         x59WVfM8lqTcARwV4ZTVT07z73rO6DIRJCa/A=
MIME-Version: 1.0
In-Reply-To: <05.0C.00376.39F038B4@pb1.pair.com>
References: <B1.A2.00376.BEC618B4@pb1.pair.com>
	 <7B.19.00376.96CD18B4@pb1.pair.com>
	 <fe05d1541002220023i27d21f2boae9d5d2720345095@mail.gmail.com>
	 <alpine.DEB.2.00.1002221401360.24578@kossu.derickrethans.nl>
	 <05.0C.00376.39F038B4@pb1.pair.com>
Date: Tue, 23 Feb 2010 01:52:28 +0100
Message-ID: <fe05d1541002221652j1781700ck3d4272f117adf9c6@mail.gmail.com>
To: Raphael Geissert <geissert@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?
From: pierre.php@gmail.com (Pierre Joye)

On Tue, Feb 23, 2010 at 12:13 AM, Raphael Geissert <geissert@php.net> wrote:
> Derick Rethans wrote:
>> On Mon, 22 Feb 2010, Pierre Joye wrote:
>>> Please don't commit this change. I remember some issues with strtol
>>> (portability, BC breaks, etc.). Please wait until we figured them out,
>>> or find back in the archives why strtol could be a bad idea.
>>
>> Poratability was indeed the reason, as well as the locale issues that
>> you mention (POSIX locales==useless). Please don't commit this.
>>
>
> Ok. Sean came up with a different patch which is being tested right now.
> If all the tests pass then I'm going to commit it.

What patch? Please do not commit anything there without first posting
to the list. There were enough breakage in this area, no need to
introduce new ones again.

Thanks for your understanding,

Cheers,
-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org