Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47031 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 42595 invoked from network); 22 Feb 2010 23:13:24 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Feb 2010 23:13:24 -0000 X-Host-Fingerprint: 200.66.18.213 unknown Received: from [200.66.18.213] ([200.66.18.213:16708] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 05/0C-00376-39F038B4 for ; Mon, 22 Feb 2010 18:13:23 -0500 Message-ID: <05.0C.00376.39F038B4@pb1.pair.com> To: internals@lists.php.net Followup-To: php.internals Lines: 15 Date: Mon, 22 Feb 2010 17:13:30 -0600 References: <7B.19.00376.96CD18B4@pb1.pair.com> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7Bit X-Posted-By: 200.66.18.213 Subject: Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}? From: geissert@php.net (Raphael Geissert) Derick Rethans wrote: > On Mon, 22 Feb 2010, Pierre Joye wrote: >> Please don't commit this change. I remember some issues with strtol >> (portability, BC breaks, etc.). Please wait until we figured them out, >> or find back in the archives why strtol could be a bad idea. > > Poratability was indeed the reason, as well as the locale issues that > you mention (POSIX locales==useless). Please don't commit this. > Ok. Sean came up with a different patch which is being tested right now. If all the tests pass then I'm going to commit it. Cheers, -- Raphael Geissert