Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:47018
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=OSisbDYOKSeRP+irHgOpyBvUaCewzRucsVKU9kG4JdffFCo4UsX90rvfDIy3S+/V9F
         FeJ4qWyEhjPQTGbAqsNpM01qCsmp2U06JsqYzFb4+5fkmSanOwmbq7XE5GBog8buyLaC
         izCQJBYwU7BwNb1kx5DtuLgmCcm66vGdSqJkk=
MIME-Version: 1.0
In-Reply-To: <7B.19.00376.96CD18B4@pb1.pair.com>
References: <B1.A2.00376.BEC618B4@pb1.pair.com>
	 <7B.19.00376.96CD18B4@pb1.pair.com>
Date: Mon, 22 Feb 2010 09:23:16 +0100
Message-ID: <fe05d1541002220023i27d21f2boae9d5d2720345095@mail.gmail.com>
To: Raphael Geissert <geissert@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] Re: why not use strtol instead of php_filter_parse_{int,hex,octal}?
From: pierre.php@gmail.com (Pierre Joye)

hi,

Please don't commit this change. I remember some issues with strtol
(portability, BC breaks, etc.). Please wait until we figured them out,
or find back in the archives why strtol could be a bad idea.

On Mon, Feb 22, 2010 at 2:21 AM, Raphael Geissert <geissert@php.net> wrote:
> Raphael Geissert wrote:
>>
>> If there's no objection, I would like to remove them entirely and use
>> strtol in php_filter_int.
>>
>
> By the way, I don't think that the fact that strtol is locale-aware should
> be a reason to make the change. Since scripts are expected to use the value
> returned by filter_var() there should be no problem with the fact that
> strings such as "100'000" are accepted as a valid integer, under certain
> locales.
>
> Cheers,
> --
> Raphael Geissert
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org