Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47015 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 35026 invoked from network); 22 Feb 2010 01:45:10 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Feb 2010 01:45:10 -0000 X-Host-Fingerprint: 200.66.16.110 unknown Received: from [200.66.16.110] ([200.66.16.110:19412] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7B/19-00376-96CD18B4 for ; Sun, 21 Feb 2010 20:22:49 -0500 Message-ID: <7B.19.00376.96CD18B4@pb1.pair.com> To: internals@lists.php.net Followup-To: php.internals Lines: 14 Date: Sun, 21 Feb 2010 19:21:51 -0600 References: MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7Bit X-Posted-By: 200.66.16.110 Subject: Re: why not use strtol instead of php_filter_parse_{int,hex,octal}? From: geissert@php.net (Raphael Geissert) Raphael Geissert wrote: > > If there's no objection, I would like to remove them entirely and use > strtol in php_filter_int. > By the way, I don't think that the fact that strtol is locale-aware should be a reason to make the change. Since scripts are expected to use the value returned by filter_var() there should be no problem with the fact that strings such as "100'000" are accepted as a valid integer, under certain locales. Cheers, -- Raphael Geissert