Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:47005 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 94428 invoked from network); 20 Feb 2010 23:06:00 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Feb 2010 23:06:00 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass; domainkeys=bad Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.42 as permitted sender) DomainKey-Status: bad X-DomainKeys: Ecelerity dk_validate implementing draft-delany-domainkeys-base-01 X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 74.125.82.42 mail-ww0-f42.google.com Received: from [74.125.82.42] ([74.125.82.42:45158] helo=mail-ww0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1E/59-29373-6DA608B4 for ; Sat, 20 Feb 2010 18:05:58 -0500 Received: by wwb29 with SMTP id 29so182903wwb.29 for ; Sat, 20 Feb 2010 15:05:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type; bh=ADZBzhw7sybmxzX05Hx2SkL0Z5ebcKVzAg5/zlxRj7w=; b=sVW/nQ+BEkufyBs8FY3npsNsE3jGzQMps2ilGdC2oiNUXDAaRKkjRiXZGwP+bYodw/ h6Cl38UH6XyGIQmHLKvS9u75zB4fyOXivdAALFuQXQ1EhgZJigmlXqrTOfa5MyO+5VGA wbsPDpCur735a2Cm8gBtYV+O8Dtd9i3bdqCBo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=pRsp3srrU2PzGGCo9u5b4nSyNGNJnU5Tui1wuziNXrv3TP7G/K3diEsIWlR1qy15T5 cEoDkFBc5bXIJ3ktx7rNGGvsyrm12m3+9ZDNOROhrKpxdlLIslnG/JWP3loOS4aBSAsv e7SnXcIQ5Vqhzg9AtQ05eTTDsFaCqqXhsVkEQ= MIME-Version: 1.0 Received: by 10.216.85.77 with SMTP id t55mr1650676wee.227.1266707154366; Sat, 20 Feb 2010 15:05:54 -0800 (PST) In-Reply-To: <7b9883441002201156i462221ccked6f1c0aa0b49b56@mail.gmail.com> References: <7b9883441002201156i462221ccked6f1c0aa0b49b56@mail.gmail.com> Date: Sun, 21 Feb 2010 00:05:54 +0100 Message-ID: To: Bostjan Skufca Cc: internals@lists.php.net, wez@php.net, kingwez@gmail.com, pajoye@php.net Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Patch for ext/openssl to support CN_match with asterisk From: pierre.php@gmail.com (Pierre Joye) hi, Is it not suppose to work already? As your patch basically does what is done earlier in the code if match fails. If there is a bug in this area, we should fix instead of adding the same thing later :) I will check this issue next week. Btw, there is no chance to get this in 5.2.13 or 5.3.2 at this stage, it is too late in the process. Thanks for your work! Cheers, On Sat, Feb 20, 2010 at 8:56 PM, Bostjan Skufca wrote: > Hi! > > I've created a patch that enables PHP to do "limited wildcard > matching" if CN_match option in stream context is specified as > '*.example.org'. > Also I have filled a bug report for this, here: > http://bugs.php.net/bug.php?id=51100 > > Patch is here: > http://source.a2o.si/php/php-ext-openssl-CN_match-wildcard.diff > > It was made against 5.2.12 but I checked it with SVN: > - for 5.2 branch the offset is only +6 lines > - for trunk it is cca +800 lines > > Can you include it in 5.2.13 release and 5.3? I know the former is > already in RC stage but this does can't break anything I believe. > > Best regards, > b. > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org