Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46987
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.219 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=Hu8JN4lvHQ1j1aMbIfjqzzMqfTxfGPy0iPAN6sbIgYsoY7gc3syxiPmvpx1Jc9GmJM
         NzTuwaXl+f0aAe5Hn/mDASKNtkaKnFbds+mQYr8Yh524I4wBLUJo95ckwGwCdxsiLRUB
         uiU9TbcVNZYNrHNEutGSLnWmqAgf3/iqIAo5Q=
MIME-Version: 1.0
In-Reply-To: <4B77F81C.5080609@php.net>
References: <d0c581731002130029x1258a8b3n4ac1d9c4e52b4b23@mail.gmail.com>
	 <4B77F81C.5080609@php.net>
Date: Sun, 14 Feb 2010 21:43:37 +0500
Message-ID: <d0c581731002140843g2fdfa026o7d8cb7166ddc3cf9@mail.gmail.com>
To: Rob Richards <rrichards@php.net>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: help with php bug #47532
From: ewgraf@gmail.com (Sokolov Evgeniy)

If you are very busy, you can answer "yes, yes, no" :)

1.
> Setting the value using the value property should behave like setting the=
 value via
> the DOMAttr constructor - input should be treated as literal text
But in this case value does not be treated:
$attr =3D new DOMAttr('test', 'foo&amp;bar');
var_dump($attr->value);
string(11) "foo&amp;bar"

So, this is bug?
May be I misunderstood something?

2. I saw you comment in the bug page.
May I write test for this cases and in this testcase show how avoid this "b=
ug"?

3. May be add $DOMAttr->getEntitiesValue() method? Because I think
htmlspecialchars_decode function are not equal libxml function
xmlEncodeEntitiesReentrant (this function use entity table). Is this
function used as analog for htmlspecialchars_decode in libxml?
Unfortunatelly, I can't find libxml analog function for
htmlspecialchars php function :(


Thank you.

2010/2/14 Rob Richards <rrichards@php.net>:
> Sokolov Evgeniy wrote:
>>
>> Hi, I wont fix this bug: http://bugs.php.net/bug.php?id=3D47532, but
>> have some questions. Can you help me?
>>
>> There is the test case: http://pastebin.org/91030
>>
>> First, I careful that when we fix this bug, we have broken BC, because
>> now when we write $attr->value =3D "foo&amp;bar"; - value has been
>> escaped and in var_dump($attr->value) we got "foo&bar". For fix this
>> bug we must remove escaping. This is right?
>>
>>
>> Second, for remove escaping I think we need use this patch:
>>
>> Index: attr.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- attr.c =A0 =A0 =A0(revision 294790)
>> +++ attr.c =A0 =A0 =A0(working copy)
>> @@ -193,7 +193,7 @@
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0convert_to_string(newval);
>> =A0 =A0 =A0 =A0}
>>
>> - =A0 =A0 =A0 xmlNodeSetContentLen((xmlNodePtr) attrp, Z_STRVAL_P(newval=
),
>> Z_STRLEN_P(newval) + 1);
>> + =A0 =A0 =A0 xmlNodeAddContentLen((xmlNodePtr) attrp, Z_STRVAL_P(newval=
),
>> Z_STRVAL_P(newval) + 1);
>>
>> =A0 =A0 =A0 =A0if (newval =3D=3D &value_copy) {
>> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0zval_dtor(newval);
>>
>>
>> This patch fix this cases:
>> $attr =3D new DOMAttr('test', 'foo&amp;bar');
>> var_dump($attr->value);
>> $attr->value =3D "foo&amp;bar";
>> var_dump($attr->value);
>>
>> but in this case we got empty value:
>> $doc =3D new DOMDocument;
>> $attr =3D $doc->createAttribute("foo");
>> $attr->value =3D "foo&amp;bar";
>> var_dump($attr->value);
>>
>> Can you explain why?
>> in first two cases wiil be call xmlNewProp libxml2 function, in last
>> case - xmlNewDocProp. Both this functions return same variable type.
>>
>>
>
> The patch is incorrect as its changing the wrong thing. The retrieval of =
the
> value is correct, it's the setting which has an issue. Setting the value
> using the value property should behave like setting the value via the
> DOMAttr constructor - input should be treated as literal text. Wont be
> changing the behavior of the value property due to BC.
>
> Rob
>
>

--
Evgeniy