Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46969 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83197 invoked from network); 9 Feb 2010 15:38:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Feb 2010 15:38:50 -0000 Authentication-Results: pb1.pair.com smtp.mail=johannes@php.net; spf=unknown; sender-id=unknown Authentication-Results: pb1.pair.com header.from=johannes@php.net; sender-id=unknown Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.134 as permitted sender) X-PHP-List-Original-Sender: johannes@php.net X-Host-Fingerprint: 83.243.58.134 mailout2.netbeat.de Linux 2.6 Received: from [83.243.58.134] ([83.243.58.134:41156] helo=mailout2.netbeat.de) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 88/46-46825-881817B4 for ; Tue, 09 Feb 2010 10:38:49 -0500 Received: (qmail 19994 invoked by uid 89); 9 Feb 2010 15:51:45 -0000 Received: from unknown (HELO ?192.168.1.21?) (postmaster%schlueters.de@93.104.37.44) by mailout2.netbeat.de with ESMTPA; 9 Feb 2010 15:51:45 -0000 X-Originator: 9e51b244e0a38413ab6a9876e36ba9df To: Sokolov Evgeniy Cc: internals@lists.php.net In-Reply-To: References: <1265723806.2988.193.camel@guybrush> Content-Type: text/plain; charset="UTF-8" Organization: php.net Date: Tue, 09 Feb 2010 16:38:44 +0100 Message-ID: <1265729924.2988.408.camel@guybrush> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] PATCH for bug #47199 From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=) Hi, On Tue, 2010-02-09 at 20:11 +0500, Sokolov Evgeniy wrote: > > did you really run this test and was it successful? - doesn't looklike > > for me. > I just run "php tests/27_bug47199.phpt" and check the result output. > Is this correct way? The easy way to run it using the test Framework is by executing make test TESTS=tests/27_bug47199.phpt from your build directory which will prepare some environment things and then run run-tests.php from PHP's source directory which has the implementation of our test system, you can also run it directly to have more ocntrol. See README.TESTING in the php-src root folder and http://qa.php.net/write-test.php for more details on the test system. If you run your test it will tell you it failed as you're tests EXPECTF section has to look something like this: --EXPECTF-- DELETE FROM %s WHERE null_field IS NULL AND not_null_field=2; Done Mind the %s place holder there! > > And please also add a link to the patch to the bug report > Can it be link on pastebin.org? For example http://pastebin.org/88880 I don't know how persistent these pastebins are, http://news.php.net/php.internals/46965 might be an alternative link though :-) johannes