Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46968
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.224 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=gfkDLuFpjPkL/DKf89WMS70m8YibqziRsCZ4fYyaiOSvo1k5dte7mg0WXd+3whPJxS
         HRquWLsw0iIGmDH5pOsJHcuQKRsZvFWYq/qprSf0mXa72jbOTQb3rr7WeKpxEd2Oi6f6
         XwINAMAPVYeVBcNIjXh/KlUfbIBwLs7YMtOxw=
MIME-Version: 1.0
In-Reply-To: <1265723806.2988.193.camel@guybrush>
References: <d0c581731002090327i273a6b0bjb0fa8d03addfca96@mail.gmail.com>
	 <1265723806.2988.193.camel@guybrush>
Date: Tue, 9 Feb 2010 20:11:14 +0500
Message-ID: <d0c581731002090711i7e3a74c3q1bd2ced6042432@mail.gmail.com>
To: =?ISO-8859-1?Q?Johannes_Schl=FCter?= <johannes@php.net>, 
	internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PATCH for bug #47199
From: ewgraf@gmail.com (Sokolov Evgeniy)

> did you really run this test and was it successful? - doesn't looklike
> for me.
I just run "php tests/27_bug47199.phpt" and check the result output.
Is this correct way?


>> Property changes on: tests/27_bug47199.phpt
> This isn't needed.

Okey, I just use previous test in this dir as example. Remove this property


> And please also add a link to the patch to the bug report
Can it be link on pastebin.org? For example http://pastebin.org/88880

2010/2/9 Johannes Schl=C3=BCter <johannes@php.net>:
> =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9,
>
> thanks for the patch.I didn't fully review it but I wonder about a
> thing:
>
> On Tue, 2010-02-09 at 16:27 +0500, =D0=A1=D0=BE=D0=BA=D0=BE=D0=BB=D0=BE=
=D0=B2 =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9 wrote:
>> Index: tests/27_bug47199.phpt
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- tests/27_bug47199.phpt =C2=A0 =C2=A0(revision 0)
>> +++ tests/27_bug47199.phpt =C2=A0 =C2=A0(revision 0)
> [...9
>> +--EXPECTF--
>> +DELETE FROM <?php echo $tbl_name;?> WHERE null_field IS NULL AND
>> not_null_field=3D2;
>> +Done
>> \ No newline at end of file
>
> did you really run this test and was it successful? - doesn't looklike
> for me.
>
>> Property changes on: tests/27_bug47199.phpt
>> ___________________________________________________________________
>> Added: svn:executable
>> =C2=A0 =C2=A0+ *
>
> This isn't needed.
>
> And please also add a link to the patch to the bug report, so it won't
> get lost, which can happen on a mailing list too easy.
>
> johannes
>
>


best regards