Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46966
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 83.243.58.134 as permitted sender)
To: =?UTF-8?Q?=D0=A1=D0=BE=D0=BA=D0=BE=D0=BB=D0=BE=D0=B2_?= =?UTF-8?Q?=D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9?= <ewgraf@gmail.com>
Cc: internals@lists.php.net
In-Reply-To: <d0c581731002090327i273a6b0bjb0fa8d03addfca96@mail.gmail.com>
References: <d0c581731002090327i273a6b0bjb0fa8d03addfca96@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Organization: php.net
Date: Tue, 09 Feb 2010 14:56:46 +0100
Message-ID: <1265723806.2988.193.camel@guybrush>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] PATCH for bug #47199
From: johannes@php.net (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

Евгений,

thanks for the patch.I didn't fully review it but I wonder about a
thing:

On Tue, 2010-02-09 at 16:27 +0500, Соколов Евгений wrote:
> Index: tests/27_bug47199.phpt
> ===================================================================
> --- tests/27_bug47199.phpt	(revision 0)
> +++ tests/27_bug47199.phpt	(revision 0)
[...9
> +--EXPECTF--
> +DELETE FROM <?php echo $tbl_name;?> WHERE null_field IS NULL AND
> not_null_field=2;
> +Done
> \ No newline at end of file

did you really run this test and was it successful? - doesn't looklike
for me.

> Property changes on: tests/27_bug47199.phpt
> ___________________________________________________________________
> Added: svn:executable
>    + *

This isn't needed.

And please also add a link to the patch to the bug report, so it won't 
get lost, which can happen on a mailing list too easy.

johannes