Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.218 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=Z+xbWM0/OJuIp2rQjWU74HcKe1vYVmw+hRMnbX7uZnxnslbhZ7ILiiu9rLUDkYS1c/
         9LmwQJdbiOLBBqzr/yVo1Xe9mBmfAS3p/oRfEcLEUCqUQqAiSVYFMY+HIjjuie/xS8ft
         5gHprVR8b+Yj1cgO3OIWuoFha54QZYUcQ7q0s=
MIME-Version: 1.0
In-Reply-To: <0_94293100_1264988130.11390.cbgrn@enoch.corp.cybozu.co.jp>
References: <0_38978400_1264671673.1668.cbgrn@enoch.corp.cybozu.co.jp>
	 <0_94293100_1264988130.11390.cbgrn@enoch.corp.cybozu.co.jp>
Date: Mon, 1 Feb 2010 09:52:03 +0100
Message-ID: <fe05d1541002010052k573b34aej9614efe376e46fbb@mail.gmail.com>
To: KITAZAKI Shigeru <shigeru_kitazaki@cybozu.co.jp>
Cc: Christopher Jones <christopher.jones@oracle.com>, internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] adding GB18030 support for mbstring
From: pierre.php@gmail.com (Pierre Joye)

hi,

Thanks for the patches :)

2010/2/1 KITAZAKI Shigeru <shigeru_kitazaki@cybozu.co.jp>:
> Thank you for your suggestion.
> Let me introduce some patches which we published. They might be useful on
> specific environments although they are not bugs.
> If I had better to report below issues as bugs, please tell me.
>
> * php_syslog.patch
> =A0syslog() function cannot properly send UTF-8 strings to event log on
> =A0Windows. This patch changes the internal API. We, however, must set
> =A0UTF-8 on 'mbstring.internal_incoding'.
> =A0In addition, this changes the severity of 'LOG_ERR' from eventlog's
> =A0warning to eventlog's error.

It has to be optional. Maybe a mbstring.syslog* option to set a given
encoding for the syslog functions.

> * php_ldap.patch
> =A0This changes the internal API to use Windows native LDAP API instead o=
f
> =A0OpenLDAP one. This is because OpenLDAP has dropped Windows support.

That's something I have done too but I don't think we can do it in a
minor version as it introduces some BC breaks. For example with SSL,
as far as I know it is not possible to use custom cerficates in custom
places (via openssl).

Where did you read that openldap stops to support windows? Last time I
checked I saw that they stoped (they never really did) to stupport
VC++ but they did support windows. Some openldap contributors even
provide windows builds as commercial packages.

Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org