Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46760
Return-Path: <php-php-dev@m.gmane.org>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 42290 invoked from network); 17 Jan 2010 03:20:14 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 17 Jan 2010 03:20:14 -0000
Authentication-Results: pb1.pair.com smtp.mail=php-php-dev@m.gmane.org; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=news@ger.gmane.org; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain m.gmane.org designates 80.91.229.12 as permitted sender)
X-PHP-List-Original-Sender: php-php-dev@m.gmane.org
X-Host-Fingerprint: 80.91.229.12 lo.gmane.org Linux 2.6
Received: from [80.91.229.12] ([80.91.229.12:45639] helo=lo.gmane.org)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 46/42-27028-CE1825B4 for <internals@lists.php.net>; Sat, 16 Jan 2010 22:20:13 -0500
Received: from list by lo.gmane.org with local (Exim 4.50)
	id 1NWLgN-0007Ud-IK
	for internals@lists.php.net; Sun, 17 Jan 2010 04:20:07 +0100
Received: from 200.92.150.117 ([200.92.150.117])
        by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <internals@lists.php.net>; Sun, 17 Jan 2010 04:20:07 +0100
Received: from geissert by 200.92.150.117 with local (Gmexim 0.1 (Debian))
        id 1AlnuQ-0007hv-00
        for <internals@lists.php.net>; Sun, 17 Jan 2010 04:20:07 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: internals@lists.php.net
Followup-To:  gmane.comp.php.devel
Date:  Sat, 16 Jan 2010 21:19:49 -0600
Lines: 51
Message-ID: <hitvkg$4qi$1@ger.gmane.org>
References:  <1263654424.3127.43.camel@guybrush> <hisveh$kcg$1@ger.gmane.org> <4B522D34.7030605@sci.fi>
Mime-Version:  1.0
Content-Type:  text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding:  7Bit
X-Gmane-NNTP-Posting-Host: 200.92.150.117
Sender: news <news@ger.gmane.org>
Subject:  Re: [PHP-DEV] Debian PHP patches
From: geissert@debian.org (Raphael Geissert)

Jani Taskinen wrote:

> 16.1.2010 20:10, Raphael Geissert wrote:
>> Some of the other patches include:
>> libdb_is_-ldb
> 
> Why? Potentially breaks things when you assume db/ being correct place..

Do you have an example of any actual case?

> 
>> 115-autoconf_ftbfs.patch
> 
> Hell no. You're breaking the configure again with this crap. I already
> reverted the idiocy once, don't even think about doing this shit again.
> PHP configure works properly only with autoconf-2.13 which was the last
> working autoconf.

Can you tell me what exactly we are breaking? divert calls should only be 
used internally by autoconf and the, apparently useless, usage of them in 
php makes it fail to build with any other autoconf.

> 
>> fix_broken_upstream_tests.patch
> 
> The soap thing seems ok.
> 
> But why are you disabling
> ext/standard/tests/general_functions/phpinfo.phpt ?? That test passes fine
> for me everywhere. The patch says:
> 
>    test suite's handling of "%s" is incompatible with this test"
> 
> Eh?

I've never seen that test actually work but I don't remember the details 
right now. Will check it next time and report.

> 
>> Which should all be merged
> 
> And next time, please include direct links to the patches, makes easier to
> follow these and comment on them. :)

Ok.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net