Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46655 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 99176 invoked from network); 12 Jan 2010 15:24:19 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 12 Jan 2010 15:24:19 -0000 X-Host-Fingerprint: 24.247.219.180 24-247-219-180.dhcp.cdwr.mi.charter.com Received: from [24.247.219.180] ([24.247.219.180:15389] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2B/06-01428-2249C4B4 for ; Tue, 12 Jan 2010 10:24:19 -0500 Message-ID: <2B.06.01428.2249C4B4@pb1.pair.com> To: internals@lists.php.net Date: Tue, 12 Jan 2010 10:24:16 -0500 User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 References: <20100112034735.GA3815@joeysmith.com> In-Reply-To: <20100112034735.GA3815@joeysmith.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Posted-By: 24.247.219.180 Subject: Re: Passing error codes through to PDOException From: auroraeosrose@gmail.com (Elizabeth M Smith) Joey Smith wrote: > Maybe I'm up in the night, but I've just opened 50728 because I discovered that all > the PDO drivers had a hardcoded 0 where I would expect to see the driver-specific > error - a user reported this in ##PHP on Freenode and I take a stab at writing the > patches that would let the individual drivers pass their error code on to the user. > > They're attached to the bug as comments (the first against the tip of 5.3.2 > [svn #293440] and the second against HEAD [svn #293440]) - but I'm also attaching > them as udiffs to this email. > > If there's a reason that the PDOExceptions don't contain their driver-specific > error codes, feel free to ignore this. > Patch looks good, Ilia put it in - thanks and as Richard said, feel free to send more PDO patches, someone with time/desire to actually do the work is always appreciated ;) Elizabeth M Smith