Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46635
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mysql.com from 192.18.6.21 cause and error)
MIME-version: 1.0
Content-transfer-encoding: 7BIT
Content-type: text/plain; CHARSET=US-ASCII; format=flowed
Date: Mon, 11 Jan 2010 18:01:34 +0100
In-reply-to: <4B4B5879.5030809@zend.com>
Sender: Andrey.Hristov@Sun.COM
To: Jess Portnoy <jess@zend.com>
Cc: PHP Developers Mailing List <internals@lists.php.net>
Message-ID: <4B4B596E.7070608@mysql.com>
References: <4B4B53A8.8010300@zend.com> <4B4B5639.1020404@mysql.com>
 <4B4B5728.20502@zend.com> <4B4B5879.5030809@zend.com>
User-Agent: Thunderbird 2.0.0.23 (X11/20090817)
Subject: Re: [PHP-DEV] [PATCH] Attempt to include
 ext/mysqlnd/mysqlnd_portability.h when building MySQLi against libmysql
From: andrey@mysql.com (Andrey Hristov)

Jess Portnoy wrote:
> Reason is MYSQL_VERSION_ID is defined here:
> ext/mysqlnd/mysqlnd_libmysql_compat.h:#define 
> MYSQL_VERSION_ID               MYSQLND_VERSION_ID
> And then, included here:
> ext/mysqli/mysqli_mysqlnd.h:#include 
> "ext/mysqlnd/mysqlnd_libmysql_compat.h"
> 
> Same is done with MySQL and PDO_MYSQL.
> 
> May the source be with you,
> Best regards,
> Jess Portnoy

MYSQL_VERSION_ID is also defined by libmysql/MySQL server. Only if you 
use pre-5.0 libmysql headers this should not compile. the bit_xxxx 
macros are specific to mysqlnd, not exposed by libmysql.

Andrey

> 
> 
> Jess Portnoy wrote:
>> Hi Andrey,
>>
>> Yes, it compiled just fine with my patch.
>> Even loaded :)
>>
>> May the source be with you,
>> Best regards,
>> Jess Portnoy
>>
>>
>>
>> Andrey Hristov wrote:
>>>  Hi Jess,
>>> does it compile after that, because I guess it doesn't. We use some 
>>> macros from that header file to be able to handle bit types correctly 
>>> in mysqli, when libmysql is used.
>>>
>>>
>>> #if MYSQL_VERSION_ID > 50002
>>>       if (mysql_fetch_field_direct(result, i)->type == MYSQL_TYPE_BIT) {
>>>         my_ulonglong llval;
>>>         char tmp[22];
>>>         switch (field_len[i]) {
>>>           case 8:llval = (my_ulonglong)  bit_uint8korr(row[i]);break;
>>>           case 7:llval = (my_ulonglong)  bit_uint7korr(row[i]);break;
>>>           case 6:llval = (my_ulonglong)  bit_uint6korr(row[i]);break;
>>>           case 5:llval = (my_ulonglong)  bit_uint5korr(row[i]);break;
>>>           case 4:llval = (my_ulonglong)  bit_uint4korr(row[i]);break;
>>>           case 3:llval = (my_ulonglong)  bit_uint3korr(row[i]);break;
>>>           case 2:llval = (my_ulonglong)  bit_uint2korr(row[i]);break;
>>>           case 1:llval = (my_ulonglong)  uint1korr(row[i]);break;
>>>         }
>>> ....
>>> #endif
>>>
>>> Best,
>>> Andrey
>>>
>>> Jess Portnoy wrote:
>>>> Hello all,
>>>>
>>>> My configure command is as follows:
>>>> ./configure --disable-xml --disable-dom --disable-libxml 
>>>> --disable-simplexml --without-pear --disable-xmlreader 
>>>> --disable-xmlwriter --without-iconv
>>>>
>>>> I then archive the result and use it to build various PHP 
>>>> extensions, among which MySQLi.
>>>> Since I did not configure with mysqlnd, I do not have ext/mysqlnd 
>>>> copied onto $PHP_PREFIX/include/php/ext, causing this following code 
>>>> to fail compilation:
>>>> #include "ext/mysqlnd/mysqlnd_portability.h"
>>>>
>>>> Attached is a suggested patch for php-5.3.1/ext/mysqli/mysqli.c and 
>>>> php-5.3.1/ext/mysqli/mysqli_api.c, basically:
>>>> +#ifdef MYSQLI_USE_MYSQLND
>>>> #include "ext/mysqlnd/mysqlnd_portability.h"
>>>> +#endif
>>>>
>>>> Thanks in advance,
>>>>
>>>
>>