Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:4660 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10259 invoked by uid 1010); 3 Oct 2003 05:43:11 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 10234 invoked from network); 3 Oct 2003 05:43:10 -0000 Received: from unknown (HELO smtp3.pp.htv.fi) (213.243.153.173) by pb1.pair.com with SMTP; 3 Oct 2003 05:43:10 -0000 Received: from netphobia.fi (cs181008.pp.htv.fi [213.243.181.8]) by smtp3.pp.htv.fi (Postfix) with ESMTP id 0E0F927AFCE; Fri, 3 Oct 2003 08:43:10 +0300 (EEST) Received: from netphobia.fi (localhost.localdomain [127.0.0.1]) by netphobia.fi (8.12.10/8.12.10) with ESMTP id h935h9vi001179; Fri, 3 Oct 2003 08:43:09 +0300 Received: from localhost (jani@localhost) by netphobia.fi (8.12.10/8.12.10/Submit) with ESMTP id h935h8va001175; Fri, 3 Oct 2003 08:43:09 +0300 X-Authentication-Warning: netphobia.fi: jani owned process doing -bs Date: Fri, 3 Oct 2003 08:43:08 +0300 (EEST) Sender: jani@netphobia.fi Reply-To: Jani Taskinen To: Moriyoshi Koizumi Cc: php-internal In-Reply-To: <20031003093224_Bj1Z6@at.wakwak.com> Message-ID: References: <20031003093224_Bj1Z6@at.wakwak.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [PHP-DEV] Fix for bug #25543 From: sniper@iki.fi (Jani Taskinen) #25543 is documentation 'bug', what exactly does your patch fix? I don't see anything wrong with set_error_handler().. --Jani On Fri, 3 Oct 2003, Moriyoshi Koizumi wrote: >Hi, > >Attached is a fix for bug #25543 (Error in set_error_handler() definition), >which is caused by disordered scheduling of the garbage collection >(zend_clean_garbage()). > >With this patch I'm adding the following two inline functions, >zend_begin_atomic() and zend_end_atomic(), to prevent GC from being >performed at the right time. Calls to those functions are inserted >at the beginning / end of zend_fetch_dimension_address(), >zend_fetch_property_address(), and some other functions of the same kind. > >I'll commit these shortly if you don't see any problem. > >Regards, > >Moriyoshi >