Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46580
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.219.226 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=PpJLi+YDqVXgswXMUoB4tVAo+aKzq19wHD70Lq92Nc99T6EXd7QZcDfHgsYgRTM9CZ
         kcrDMefJfEe+/kGOhPPo4I4L6FjH4h6BIdfhxXN3ST4z4gq1g7BJek87QxmOLVRjvmRw
         amR/6QY41PspX8gXYTNz3qQ7axy026Tu675KI=
MIME-Version: 1.0
In-Reply-To: <e666c3890912281801t7ed60f9emab0652fff1e9bd06@mail.gmail.com>
References: <78.83.26502.F1DD83B4@pb1.pair.com> <4B38DDD3.8010108@hexon.cx>
	 <A4.58.26502.869393B4@pb1.pair.com>
	 <e666c3890912281520q632c4f0diecb804cab2605ee@mail.gmail.com>
	 <4B394CDC.9040709@warpmail.net>
	 <e666c3890912281801t7ed60f9emab0652fff1e9bd06@mail.gmail.com>
Date: Thu, 31 Dec 2009 10:35:04 +0100
Message-ID: <cd5680a20912310135g1513268oc2df986869dd9485@mail.gmail.com>
To: Etienne Kneuss <colder@php.net>
Cc: Clint Priest <cpriest@warpmail.net>, internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] is_array on objects with ArrayAccess or Iterator 
	implementations
From: indeyets@gmail.com (Alexey Zakhlestin)

On Tue, Dec 29, 2009 at 3:01 AM, Etienne Kneuss <colder@php.net> wrote:
> Hi,
>
> On Tue, Dec 29, 2009 at 1:27 AM, Clint Priest <cpriest@warpmail.net> wrot=
e:
>> Etienne Kneuss wrote:
>>>
>>> On Tue, Dec 29, 2009 at 12:04 AM, Clint Priest <cpriest@warpmail.net>
>>> wrote:
>>>>
>>>> Unfortunately $x instanceOf ArrayAccess doesn't return true when $x is
>>>> indeed an array.
>>>
>>> Making is_array return true for objects implementing ArrayAccess is a
>>> bad idea, for two main reasons:
>>>
>>> 1) is_array is a type check, and we should still be able to
>>> distinguish real arrays from objects
>>
>> That's true of course, definitely would need to be able to distinguish.
>>
>>> 2) ArrayAccess does not guarantee that an object will behave like an
>>> array, (e.g. you won't be able to use sort() on an object implementing
>>> ArrayAccess.
>>
>> I wonder if this is something that users would be expecting, that any
>> function which took an array would also take an object that implements
>> certain interfaces (such as ArrayAccess and perhaps Countable).
>>
>>> If, in your case, you want to accept both arrays and ArrayAccess
>>> objects, I guess if (is_array($v) || $v instanceof ArrayAccess) =C2=A0i=
s a
>>> sufficiently good way to check.
>>>
>>
>> I'm finding myself implementing ArrayAccess more and more often because =
its
>> so transparent to the consumer. =C2=A0The reason this came up is because=
 I was
>> considering returning all arrays from a certain section of my shared cod=
e
>> library always be an array object so that things like
>> $tblArray->pluck('Value') could be done, rather than array_pluck() type
>> functionality.
>>
>> That got me to thinking about all of the is_array() calls I would need t=
o
>> replace throughout the codebase.
>>
>> Would it be terribly difficult to make objects with ArrayAccess complete=
ly
>> interchangable anywhere an array element would be required by a function=
?
>
> Yes, definitely, it would be a quite big amount of work (basically
> rewriting every functions dealing with arrays), and the interface that
> ArrayAccess proposes isn't enough for most array tasks.

can we go other way round and allow to use array's in ArrayAccess
context? I'd love to use it as a type-hint.


--=20
Alexey Zakhlestin
http://www.milkfarmsoft.com/
Sent from Prague, Czech Republic