Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46517 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 48259 invoked from network); 24 Dec 2009 00:15:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Dec 2009 00:15:21 -0000 Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Received: from [63.205.162.117] ([63.205.162.117:46113] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 55/15-21037-892B23B4 for ; Wed, 23 Dec 2009 19:15:21 -0500 Received: from us-gw1.zend.com (us-ex1.zend.net [192.168.16.5]) by us-mr1.zend.com (Postfix) with ESMTP id CCD9643FB5; Wed, 23 Dec 2009 09:19:06 -0800 (PST) Received: from [192.168.16.93] ([192.168.16.93]) by us-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 23 Dec 2009 16:15:17 -0800 Message-ID: <4B32B295.5090104@zend.com> Date: Wed, 23 Dec 2009 16:15:17 -0800 Organization: Zend Technologies User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b2pre Thunderbird/3.0 MIME-Version: 1.0 To: Hans-Peter Oeri CC: internals@lists.php.net References: <75.F8.00186.3A7023B4@pb1.pair.com> In-Reply-To: <75.F8.00186.3A7023B4@pb1.pair.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 24 Dec 2009 00:15:17.0739 (UTC) FILETIME=[2C23DBB0:01CA842E] Subject: Re: [PHP-DEV] [PATCH] zend_parse_method_parameters_ex: don't ignore flags From: stas@zend.com (Stanislav Malyshev) Hi! > As of now, zend_parse_method_parameters_ex does ignore the ex-flags if > called in a procedural context. > > NB: Calling it in a procedural context is explicitely handled in the > code! It's not a false use of the function. > > I suppose, the body was copied from zend_parse_method_parameters and the > "flags" correction got lost in one case. Looks like it. Funny thing is there seems to be no core in the main repo using this particular function. But I committed the fix anyway, as it seems to be a clear bug. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com