Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46501 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 26402 invoked from network); 23 Dec 2009 12:05:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 23 Dec 2009 12:05:56 -0000 X-Host-Fingerprint: 188.62.49.6 6-49.62-188.cust.bluewin.ch Received: from [188.62.49.6] ([188.62.49.6:19480] helo=localhost.localdomain) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 75/F8-00186-3A7023B4 for ; Wed, 23 Dec 2009 07:05:56 -0500 Message-ID: <75.F8.00186.3A7023B4@pb1.pair.com> To: internals@lists.php.net Date: Wed, 23 Dec 2009 13:05:49 +0100 User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070606050500070906060800" X-Posted-By: 188.62.49.6 Subject: [PATCH] zend_parse_method_parameters_ex: don't ignore flags From: hp@oeri.ch (Hans-Peter Oeri) --------------070606050500070906060800 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi! As of now, zend_parse_method_parameters_ex does ignore the ex-flags if called in a procedural context. NB: Calling it in a procedural context is explicitely handled in the code! It's not a false use of the function. I suppose, the body was copied from zend_parse_method_parameters and the "flags" correction got lost in one case. HP --------------070606050500070906060800 Content-Type: text/x-patch; name="zend_parse_method_parameters_ex.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="zend_parse_method_parameters_ex.diff" diff -r 8d27b606e890 Zend/zend_API.c --- a/Zend/zend_API.c Wed Dec 23 10:40:28 2009 +0100 +++ b/Zend/zend_API.c Wed Dec 23 13:00:50 2009 +0100 @@ -923,7 +923,7 @@ RETURN_IF_ZERO_ARGS(num_args, p, quiet); va_start(va, type_spec); - retval = zend_parse_va_args(num_args, type_spec, &va, 0 TSRMLS_CC); + retval = zend_parse_va_args(num_args, type_spec, &va, flags TSRMLS_CC); va_end(va); } else { p++; --------------070606050500070906060800--