Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46496
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.78.24 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=xYh5jjWn5+JcoVPDB+KDb19QjPfmUEV+OqXFi7cscgeaLW7TG8/fg9UQRBCcEE2RhL
         8p8Nrn3WKvw2hmpnfBdK6CuNdccTZeCJoYKlgeLFdUeVoBk5drAbVCoFxIFbKjkukfUe
         wJkVWJDCyreJoVBEiLLW99EVHCnzr0Atng7jk=
MIME-Version: 1.0
In-Reply-To: <5e33430b0912220710r6effa11eq56e296e73041e8f1@mail.gmail.com>
References: <5e33430b0912220710r6effa11eq56e296e73041e8f1@mail.gmail.com>
Date: Tue, 22 Dec 2009 12:38:02 -0800
Message-ID: <c25f8d340912221238s43aadaefjb0ea37b47e6a00ad@mail.gmail.com>
To: X Ryl <boite.pour.spam@gmail.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] Fix for 32 bits limit on file size (see bug 
	48886)
From: 0xcafefeed@gmail.com (mm w)

Thx,

yep a long convertion, not a big deal, we don't work with 4.3GB files
:-D, well minded people try to avoid that

On Tue, Dec 22, 2009 at 7:10 AM, X Ryl <boite.pour.spam@gmail.com> wrote:
> Hi,
>
> =C2=A0I'm not a C developer, so I can't really help with the attached pat=
ch.
> However, I've tried it with PHP 5.3.0 version I have and it does what it
> claims, that is, it gives correct behaviour for the following functions:
> filesize, fstat, stat when used on file > 4GB on a 32 bits machine.
> Currently, php 5.x doesn't give the correct output for this code (on my
> 32bits server):
> echo filesize("path/to/4.3GBfile");=C2=A0 // expecting 4617089843, got 32=
2122547
>
> With the patch applied, the good result is returned.
> From the patch author, it improves the tests results.
> From what I've understood, the patch switch to php's double type when the
> size overflow the 32bits limit of int.
> It doesn't seem to break any existing behaviour (I'm using this on my
> multiple project since july, and no bad experience so far).
>
> The explaination by the patch author: http://bugs.php.net/bug.php?id=3D48=
886
>
>
>
>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>