Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46490
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.78.27 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type;
        b=NfrWxrH8egi5BGm5qawDcpcXAFsCg4ptVFrgkytncoKJVkUOpjD1e73UKshNJtWUld
         /APUHT8KnpRLPhGIveHZEu64ev0Z+yKJxfMeA/ZyteKRfLwV0k+Cov2po5Fs7jivZx3H
         if/eQUbRrIZKqi1qUAWp5gUjo2W94tqVAs+Yo=
MIME-Version: 1.0
Date: Tue, 22 Dec 2009 16:10:15 +0100
Message-ID: <5e33430b0912220710r6effa11eq56e296e73041e8f1@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/mixed; boundary=000e0ce0b72670afa6047b529aeb
Subject: [PATCH] Fix for 32 bits limit on file size (see bug 48886)
From: boite.pour.spam@gmail.com (X Ryl)

--000e0ce0b72670afa6047b529aeb
Content-Type: multipart/alternative; boundary=000e0ce0b72670af98047b529ae9

--000e0ce0b72670af98047b529ae9
Content-Type: text/plain; charset=ISO-8859-1

Hi,

 I'm not a C developer, so I can't really help with the attached patch.
However, I've tried it with PHP 5.3.0 version I have and it does what it
claims, that is, it gives correct behaviour for the following functions:
filesize, fstat, stat when used on file > 4GB on a 32 bits machine.
Currently, php 5.x doesn't give the correct output for this code (on my
32bits server):
echo filesize("path/to/4.3GBfile");  // expecting 4617089843, got 322122547

With the patch applied, the good result is returned.
From the patch author, it improves the tests results.
From what I've understood, the patch switch to php's double type when the
size overflow the 32bits limit of int.
It doesn't seem to break any existing behaviour (I'm using this on my
multiple project since july, and no bad experience so far).

The explaination by the patch author: http://bugs.php.net/bug.php?id=48886

--000e0ce0b72670af98047b529ae9
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi, <br><br>=A0I&#39;m not a C developer, so I can&#39;t really help with t=
he attached patch. However, I&#39;ve tried it with PHP 5.3.0 version I have=
 and it does what it claims, that is, it gives correct behaviour for the fo=
llowing functions:<br>
filesize, fstat, stat when used on file &gt; 4GB on a 32 bits machine.<br>C=
urrently, php 5.x doesn&#39;t give the correct output for this code (on my =
32bits server):<br>echo filesize(&quot;path/to/4.3GBfile&quot;);=A0 // expe=
cting 4617089843, got 322122547<br>
<br>With the patch applied, the good result is returned.<br>From the patch =
author, it improves the tests results.<br>From what I&#39;ve understood, th=
e patch switch to php&#39;s double type when the size overflow the 32bits l=
imit of int.<br>
It doesn&#39;t seem to break any existing behaviour (I&#39;m using this on =
my multiple project since july, and no bad experience so far).<br><br>The e=
xplaination by the patch author: <a href=3D"http://bugs.php.net/bug.php?id=
=3D48886">http://bugs.php.net/bug.php?id=3D48886</a><br>
<br><br>=A0<br><br><br>

--000e0ce0b72670af98047b529ae9--
--000e0ce0b72670afa6047b529aeb--