Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46423
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain loyet.net from 209.85.223.195 cause and error)
MIME-Version: 1.0
In-Reply-To: <b9defe2f0912150419s2e701ffdp6a871d1c5e80029c@mail.gmail.com>
References: <3bea96c40912141216u6019bc9bv4bdf054a4cd1919f@mail.gmail.com>
	 <4B275138.4040200@iki.fi> <4B27538C.7030108@daylessday.org>
	 <4B27573D.6080601@iki.fi> <4B2758E6.2070506@daylessday.org>
	 <b9defe2f0912150419s2e701ffdp6a871d1c5e80029c@mail.gmail.com>
Date: Tue, 15 Dec 2009 13:24:13 +0100
Message-ID: <3bea96c40912150424u616a05d4k38be702f34d5a14b@mail.gmail.com>
To: Tjerk Anne Meesters <datibbaw@php.net>
Cc: Antony Dovgal <tony@daylessday.org>, jani.taskinen@iki.fi, 
	php-dev <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + 
	homogenize log message about pool
From: jerome@loyet.net (=?ISO-8859-1?B?Suly9G1lIExveWV0?=)

2009/12/15 Tjerk Anne Meesters <datibbaw@php.net>:
> The only two things that would come up after reading Jani's email is:

so am I

> 1) Make the log string configurable, such as CustomLog in apache

Yes but CustomLog is for access log, this feature is not present in
php-fpm (should it be ?)
All the log message (my patch is changing) are error, debug or warning
message like:
- WARNING: unable to open log file
- php-fpm started well
- unable to fork
...
There is no way to make this configurable ... because it's totally useless

> 2) Configure the log level threshold, though I think that should
> already be there in the first place.

Yes it's already in place
>
> On 12/15/09, Antony Dovgal <tony@daylessday.org> wrote:
>> On 15.12.2009 12:30, Jani Taskinen wrote:
>>>> Surely log_level is configurable.
>>>> Jerome just changed error level of some error messages to reduce the
>>>> amount of notices in the log.
>>>
>>> I replied badly, I meant ALL the points in the mail. Configurable log
>>> entries, levels, etc. Not some static fprintf() stuff. :)
>>
>> Well, now you've lost me completely.
>>
>>> 1- makes log message about pool concistent. I set it to "[pool %s]
>>> message". Before there where different variants:
>>> pool %s,
>>> foo (pool %s) bar
>>> [pool %s]
>>> [%s]
>>>
>>> 2- corrects some log messages which were not very meaningful for end users
>>
>> Configurable error messages, huh?
>>
>>> 3- Some log level have been switched from NOTICE to DEBUG, so that the
>>> log_file in normal operation would not be a nightmare to read (with a
>>> lot of anoying and useless messages for end users)
>>
>> Configurable error level for certain error messages?
>>
>> --
>> Wbr,
>> Antony Dovgal
>> ---
>> http://pinba.org - realtime statistics for PHP
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
>
>
> --
> --
> Tjerk
>