Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46422
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.171 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type;
        b=NI6rh28VYZ+Kl12XBqlS5k3h9tdx2McriEHWYg+dz/kxMukiub27+e2zWPKlVV/L3Z
         dNrxtl4JefU8718HaWUwOdbT/BUhFywdZrzxjpnT/LH8Mem4yebxcuFGPzbz16lrUvum
         nMEy0GtM6Dti7DjKp3BAsFWiPyMGTmqTYx/2c=
MIME-Version: 1.0
Sender: tjerk.meesters@gmail.com
In-Reply-To: <4B2758E6.2070506@daylessday.org>
References: <3bea96c40912141216u6019bc9bv4bdf054a4cd1919f@mail.gmail.com>
	 <4B275138.4040200@iki.fi> <4B27538C.7030108@daylessday.org>
	 <4B27573D.6080601@iki.fi> <4B2758E6.2070506@daylessday.org>
Date: Tue, 15 Dec 2009 20:19:45 +0800
Message-ID: <b9defe2f0912150419s2e701ffdp6a871d1c5e80029c@mail.gmail.com>
To: Antony Dovgal <tony@daylessday.org>, jani.taskinen@iki.fi, 
	=?ISO-8859-1?B?Suly9G1lIExveWV0?= <jerome@loyet.net>, 
	php-dev <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] [PATCH] fpm/typo: change some log about dynamic + 
	homogenize log message about pool
From: datibbaw@php.net (Tjerk Anne Meesters)

The only two things that would come up after reading Jani's email is:
1) Make the log string configurable, such as CustomLog in apache
2) Configure the log level threshold, though I think that should
already be there in the first place.

On 12/15/09, Antony Dovgal <tony@daylessday.org> wrote:
> On 15.12.2009 12:30, Jani Taskinen wrote:
>>> Surely log_level is configurable.
>>> Jerome just changed error level of some error messages to reduce the
>>> amount of notices in the log.
>>
>> I replied badly, I meant ALL the points in the mail. Configurable log
>> entries, levels, etc. Not some static fprintf() stuff. :)
>
> Well, now you've lost me completely.
>
>> 1- makes log message about pool concistent. I set it to "[pool %s]
>> message". Before there where different variants:
>> pool %s,
>> foo (pool %s) bar
>> [pool %s]
>> [%s]
>>
>> 2- corrects some log messages which were not very meaningful for end users
>
> Configurable error messages, huh?
>
>> 3- Some log level have been switched from NOTICE to DEBUG, so that the
>> log_file in normal operation would not be a nightmare to read (with a
>> lot of anoying and useless messages for end users)
>
> Configurable error level for certain error messages?
>
> --
> Wbr,
> Antony Dovgal
> ---
> http://pinba.org - realtime statistics for PHP
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>


-- 
--
Tjerk