Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:46395
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.219.219 as permitted sender)
DomainKey-Status: bad
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=googlemail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        b=XUbdwoEaiF1DvRzPKFFSFXWRRH1K/EnJAHAvx5LZ1EVioU/wdko6d2CJ1wlBa4nXka
         0pHlywJEJW/FKORVi0W0oucQUSgOD6NMIyMK3NWpVeDIA8qC9YlgrCfFTHLONjP80t2x
         QHON9nadsvxE70zW0+u1JrBZiUfkvmbMpakXI=
MIME-Version: 1.0
In-Reply-To: <4B202FC6.6010400@zend.com>
References: <d4b907690911212112t51fcbd89s4d37e13a7cc281c9@mail.gmail.com>
	 <4B1F0CFE.4040505@zend.com>
	 <d4b907690912091510s3c792700k7187252dbf14f4f1@mail.gmail.com>
	 <4B202FC6.6010400@zend.com>
Date: Wed, 9 Dec 2009 23:36:36 +0000
Message-ID: <d4b907690912091536n69a7dcdbgb63a649c24e5c934@mail.gmail.com>
To: Stanislav Malyshev <stas@zend.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary=000e0ce0d4885830e2047a54292b
Subject: Re: [PHP-DEV] [PATCH] session_set_save_handler(class)
From: arraypad@googlemail.com (Arpad Ray)

--000e0ce0d4885830e2047a54292b
Content-Type: text/plain; charset=ISO-8859-1

Hi,

On Wed, Dec 9, 2009 at 11:16 PM, Stanislav Malyshev <stas@zend.com> wrote:

> It now raises an error rather than segfaulting if the user module is
>> selected but no handler has been registered. This should really halt
>> execution which it doesn't at the moment but I'll raise that separately.
>>
>
> I'd say if it's "user" then it should return an error from the set_handler
> function.
>
>
>
Do you mean when session_set_save_handler() is called more than once? That's
quite harmless and I think it would be useful to wrap frameworks' session
handlers.

The error I'm talking about is when the ini setting session.save_handler is
set to user - we get this during module start-up when the ini settings are
registered.
This is an erroneous configuration since we have no way of registering the
user handlers at that time.


>     4. I think it also makes sense to allow passing object instead of
>> class.
>>
>>
>> I've allowed objects to be passed now but I think this should probably
>> be discouraged since it's going to be called in a static context anyway.
>>
>
> I don't see anything inherently wrong with having session object.
>
>
I don't think that there's anything inherently wrong with it, just that it's
slightly inefficient and offers no benefits since $this isn't available.

Regards,

Arpad

--000e0ce0d4885830e2047a54292b--