Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:46393 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 74515 invoked from network); 9 Dec 2009 23:16:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Dec 2009 23:16:27 -0000 Authentication-Results: pb1.pair.com header.from=stas@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=stas@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 63.205.162.117 as permitted sender) X-PHP-List-Original-Sender: stas@zend.com X-Host-Fingerprint: 63.205.162.117 us-mr1.zend.com Linux 2.4/2.6 Received: from [63.205.162.117] ([63.205.162.117:45501] helo=us-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DC/E9-25115-9CF202B4 for ; Wed, 09 Dec 2009 18:16:26 -0500 Received: from us-gw1.zend.com (us-ex1.zend.net [192.168.16.5]) by us-mr1.zend.com (Postfix) with ESMTP id 9D4ECE11FF; Wed, 9 Dec 2009 15:13:22 -0800 (PST) Received: from [192.168.16.93] ([192.168.16.93]) by us-gw1.zend.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 9 Dec 2009 15:16:22 -0800 Message-ID: <4B202FC6.6010400@zend.com> Date: Wed, 09 Dec 2009 15:16:22 -0800 Organization: Zend Technologies User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1pre Thunderbird/3.0 MIME-Version: 1.0 To: Arpad Ray CC: internals@lists.php.net References: <4B1F0CFE.4040505@zend.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 09 Dec 2009 23:16:22.0024 (UTC) FILETIME=[9EE81080:01CA7925] Subject: Re: [PHP-DEV] [PATCH] session_set_save_handler(class) From: stas@zend.com (Stanislav Malyshev) Hi! > 2. What happens if session module is set to "user" in configuration > - what old_mod will be then and how this patch will work? > > > It now raises an error rather than segfaulting if the user module is > selected but no handler has been registered. This should really halt > execution which it doesn't at the moment but I'll raise that separately. I'd say if it's "user" then it should return an error from the set_handler function. > 4. I think it also makes sense to allow passing object instead of class. > > > I've allowed objects to be passed now but I think this should probably > be discouraged since it's going to be called in a static context anyway. I don't see anything inherently wrong with having session object. -- Stanislav Malyshev, Zend Software Architect stas@zend.com http://www.zend.com/ (408)253-8829 MSN: stas@zend.com